Document six recurring non-issue shapes in the security model - #72239
Open
potiuk wants to merge 1 commit into
Open
Document six recurring non-issue shapes in the security model#72239potiuk wants to merge 1 commit into
potiuk wants to merge 1 commit into
Conversation
The security team re-derives the same dispositions from first principles each time they arrive: hardening with no reachable path, findings premised on a misconfiguration, restatements of decisions this document already records, components the project does not release, preconditions that already grant the capability being demonstrated, and values the masking contract was never claimed to cover. Writing them down lets a reporter check their finding before spending their own time on it, and gives triage something to point at instead of composing the reasoning again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What is NOT considered a security vulnerability opens by asking security researchers and AI agents to read it before reporting. It works: the shapes it names largely stop arriving. The shapes it does not name keep arriving, and each one costs a triage cycle to re-derive — the reasoning ends up in a private thread, so the next instance is reasoned out from scratch.
Six dispositions recur often enough to be worth writing down. Each is drawn from how the security team has actually been closing reports, not from speculation about what might arrive.
What
Six new entries, appended to the existing section:
import_string()call site" report with no route to it.extraplus names matching[core] sensitive_var_conn_names. Identity fields are deliberately excluded —login,user,usernameare absent fromDEFAULT_SENSITIVE_FIELDS— and values placed in a Dag run configuration were never claimed to be masked. A value that is within the contract and leaks is still a real bug.Both factual claims in the last entry were checked against the code rather than asserted:
shared/secrets_masker/.../secrets_masker.py(DEFAULT_SENSITIVE_FIELDScontains no identity field) andtask-sdk/.../execution_time/context.py(_mask_connection_secretsmaskspasswordandextra).Scope
Additions only — no existing entry is narrowed and nothing previously in scope moves out of it. The entries are written as generalised categories; no report, reporter, tool or vendor is identifiable from the text.
The first entry is deliberately framed as a redirection rather than a rejection, because that is what it is: findings sent to the public track are frequently fixed within days.
Note for the reviewer
This touches the same section as #72172, which is still open. The two were written to append at different points, so they should merge without conflict, but whichever lands second is worth a glance.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines