Add json line support for DocumentLoaderOperator - #72246
Open
jeff3071 wants to merge 3 commits into
Open
Conversation
jeff3071
requested review from
Lee-W,
ashb,
gopidesupavan and
kaxil
as code owners
August 29, 2026 06:36
| result = op.execute(context=MagicMock()) | ||
|
|
||
| assert len(result) == 1 | ||
| assert result[0]["text"] == "name: kept" |
Contributor
There was a problem hiding this comment.
Could we add coverage for an invalid JSON line? Since each line is parsed separately, the raw JSONDecdeError will generally report line 1 rather than the line’s position in the JSONL file.
Contributor
Author
There was a problem hiding this comment.
Great catch! Fixed in b6033b0. JSONDecodeError now reports the correct line number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
DocumentLoaderOperatorsupports regular JSON, but it does not recognize JSON Lines (.jsonl) files.What
.jsonlparsing without additional dependencies.item_indexmetadata.source_byteswithfile_type=".jsonl".Different with JSON file
For example, this regular JSON file produces two documents because its top-level array is expanded:
[ {"body": "First"}, {"body": "Second"} ]In a JSON Lines file, each non-empty line produces exactly one document. The array on the first line remains one document instead of being expanded, so this file also produces two documents:
[{"body": "First"}, {"body": "Second"}] {"body": "Third"}Testing
Before
After
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-5.6-sol) following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.