[v3-3-test] Make the CI unit test timeout fire before the job timeout… - #72299
Merged
Conversation
… does (apache#72259) * Make the CI unit test timeout fire before the job timeout does The test timeout exists so that a hanging test group is stopped while the job still has time to dump the container logs and upload them as artifacts. It never got that chance. The alarm is armed in the last step of the job, but the job budget starts at the first one, and checking out the repo, pulling the CI image and running the migration tests routinely take twenty minutes or more before any test runs. A fixed sixty minute test timeout could therefore only fire in a job GitHub had already cancelled, so every hang surfaced as a bare job timeout with no logs to explain it. * Print the CI test budget in minutes and seconds The line reported the budget left in seconds next to a job timeout in minutes, so anyone reading it had to convert one to compare them. (cherry picked from commit 14397bc) Co-authored-by: rjgoyln <151457491+rjgoyln@users.noreply.github.com>
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496 and
jscheffl
as code owners
August 30, 2026 17:56
vatsrahul1001
pushed a commit
that referenced
this pull request
Sep 7, 2026
… does (#72259) (#72299) * Make the CI unit test timeout fire before the job timeout does The test timeout exists so that a hanging test group is stopped while the job still has time to dump the container logs and upload them as artifacts. It never got that chance. The alarm is armed in the last step of the job, but the job budget starts at the first one, and checking out the repo, pulling the CI image and running the migration tests routinely take twenty minutes or more before any test runs. A fixed sixty minute test timeout could therefore only fire in a job GitHub had already cancelled, so every hang surfaced as a bare job timeout with no logs to explain it. * Print the CI test budget in minutes and seconds The line reported the budget left in seconds next to a job timeout in minutes, so anyone reading it had to convert one to compare them. (cherry picked from commit 14397bc) Co-authored-by: rjgoyln <151457491+rjgoyln@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… does (#72259)
The test timeout exists so that a hanging test group is stopped while the job still has time to dump the container logs and upload them as artifacts. It never got that chance. The alarm is armed in the last step of the job, but the job budget starts at the first one, and checking out the repo, pulling the CI image and running the migration tests routinely take twenty minutes or more before any test runs. A fixed sixty minute test timeout could therefore only fire in a job GitHub had already cancelled, so every hang surfaced as a bare job timeout with no logs to explain it.
The line reported the budget left in seconds next to a job timeout in minutes, so anyone reading it had to convert one to compare them. (cherry picked from commit 14397bc)
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.