Skip to content

[v3-3-test] Make the CI unit test timeout fire before the job timeout… - #72299

Merged
potiuk merged 1 commit into
apache:v3-3-testfrom
potiuk:backport-14397bc-v3-3-test
Aug 30, 2026
Merged

[v3-3-test] Make the CI unit test timeout fire before the job timeout…#72299
potiuk merged 1 commit into
apache:v3-3-testfrom
potiuk:backport-14397bc-v3-3-test

Conversation

@potiuk

@potiuk potiuk commented Aug 30, 2026

Copy link
Copy Markdown
Member

… does (#72259)

  • Make the CI unit test timeout fire before the job timeout does

The test timeout exists so that a hanging test group is stopped while the job still has time to dump the container logs and upload them as artifacts. It never got that chance. The alarm is armed in the last step of the job, but the job budget starts at the first one, and checking out the repo, pulling the CI image and running the migration tests routinely take twenty minutes or more before any test runs. A fixed sixty minute test timeout could therefore only fire in a job GitHub had already cancelled, so every hang surfaced as a bare job timeout with no logs to explain it.

  • Print the CI test budget in minutes and seconds

The line reported the budget left in seconds next to a job timeout in minutes, so anyone reading it had to convert one to compare them. (cherry picked from commit 14397bc)


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

… does (apache#72259)

* Make the CI unit test timeout fire before the job timeout does

The test timeout exists so that a hanging test group is stopped while the job
still has time to dump the container logs and upload them as artifacts. It
never got that chance. The alarm is armed in the last step of the job, but the
job budget starts at the first one, and checking out the repo, pulling the CI
image and running the migration tests routinely take twenty minutes or more
before any test runs. A fixed sixty minute test timeout could therefore only
fire in a job GitHub had already cancelled, so every hang surfaced as a bare
job timeout with no logs to explain it.

* Print the CI test budget in minutes and seconds

The line reported the budget left in seconds next to a job timeout in minutes,
so anyone reading it had to convert one to compare them.
(cherry picked from commit 14397bc)

Co-authored-by: rjgoyln <151457491+rjgoyln@users.noreply.github.com>
@potiuk
potiuk merged commit b7b166f into apache:v3-3-test Aug 30, 2026
7 checks passed
@potiuk
potiuk deleted the backport-14397bc-v3-3-test branch August 30, 2026 17:56
vatsrahul1001 pushed a commit that referenced this pull request Sep 7, 2026
… does (#72259) (#72299)

* Make the CI unit test timeout fire before the job timeout does

The test timeout exists so that a hanging test group is stopped while the job
still has time to dump the container logs and upload them as artifacts. It
never got that chance. The alarm is armed in the last step of the job, but the
job budget starts at the first one, and checking out the repo, pulling the CI
image and running the migration tests routinely take twenty minutes or more
before any test runs. A fixed sixty minute test timeout could therefore only
fire in a job GitHub had already cancelled, so every hang surfaced as a bare
job timeout with no logs to explain it.

* Print the CI test budget in minutes and seconds

The line reported the budget left in seconds next to a job timeout in minutes,
so anyone reading it had to convert one to compare them.
(cherry picked from commit 14397bc)

Co-authored-by: rjgoyln <151457491+rjgoyln@users.noreply.github.com>
@vatsrahul1001 vatsrahul1001 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Sep 8, 2026
@vatsrahul1001 vatsrahul1001 added this to the Airflow 3.3.2 milestone Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants