-
Notifications
You must be signed in to change notification settings - Fork 4k
MINOR: [R] Add the explicit mirror to install R dependencies #48649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
|
@github actions crossbow submit test-r-devdocs |
jonkeane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will want to pull out + add a bit of discussion explaining that this is really for someone who hasn't worked with R before and hasn't already set up their preferred repos.
| popd # To go back to the root directory of the project, from cpp/build | ||
| pushd r | ||
| R -e "install.packages('remotes'); remotes::install_deps(dependencies = TRUE)" | ||
| R -e 'install.packages("remotes", repos="https://cloud.r-project.org"); remotes::install_deps(dependencies = TRUE)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to pull this out into the text. For R users / developers they will have a preferred repo source configured already. For example, if someone is on linux + pointed at Posit Public Package manager for binaries, this will override that + be much slower for them.
I've also triggered a devdocs CI job to see if this impacts that too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that's fine! I am fine with closing this too. I'll leave this to you 🫡
|
@github-actions crossbow submit test-r-devdocs |
|
Revision: 2476bc3 Submitted crossbow builds: ursacomputing/crossbow @ actions-c6e5649cbb
|
Rationale for this change
Otherwise, it complains that the mirror has to be manually set in, e.g., R profile.
Should be best to make it self-contained.
What changes are included in this PR?
This PR fixes the R dev guides (https://arrow.apache.org/docs/4.0/r/articles/developing.html) to provide an explicit mirror when downloading related dependencies.
Are these changes tested?
Manually tested when setting up the dev.
Are there any user-facing changes?
No, dev-only.