GH-48662: [R] Remove trace$calls %||% trace$call once rlang > 0.4.11 is released #48663
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HyukjinKwon
force-pushed
the
GH-48662
branch
from
6d9b8bc to
9c97dc7
Compare
github-actions
bot
added
awaiting merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
arrow/r/R/metadata.R
Line 75 in ff5572c
arrow/r/R/metadata.R
Line 148 in ff5572c
rlang changed its callstack API: older versions used trace$calls, newer versions (rlang 0.4.11+) use trace$call from r-lib/rlang#1255
This was released 5 years ago so should be safe to remove this workaround.
What changes are included in this PR?
This PR removes
trace$callsworkaround (per newertrace$call).Are these changes tested?
Existing CI should cover this.
Are there any user-facing changes?
No, dev-only.
trace$calls %||% trace$callonce rlang > 0.4.11 is released #48662