Skip to content

GH-49445: [C++]: Fix potential dereference of nullptr #49483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CT811 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

GH-49445: [C++]: Fix potential dereference of nullptr #49483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cpp/src/arrow/c/bridge.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ namespace {
struct ExportedArrayPrivateData : PoolAllocationMixin<ExportedArrayPrivateData> {
// The buffers are owned by the ArrayData member
SmallVector<const void*, 3> buffers_;
struct ArrowArray dictionary_ {};
struct ArrowArray dictionary_{};
SmallVector<struct ArrowArray, 1> children_;
SmallVector<struct ArrowArray*, 4> child_pointers_;

Expand Down Expand Up @@ -2629,6 +2629,10 @@ class AsyncRecordBatchIterator {

private_data->state_->schema_ = maybe_schema.MoveValueUnsafe();
private_data->fut_iterator_.MarkFinished(private_data->state_);
if (self->producer == nullptr) {
private_data->fut_iterator_.MarkFinished(Status::Invalid("Missing producer"));
return EINVAL;
}
self->producer->request(self->producer,
static_cast<int64_t>(private_data->state_->queue_size_));
return 0;
Expand Down