GH-49890: [Dev] Group files under component comment headers in .github/CODEOWNERS#49891
GH-49890: [Dev] Group files under component comment headers in .github/CODEOWNERS#49891kevingurney wants to merge 1 commit intoapache:mainfrom
.github/CODEOWNERS#49891Conversation
…` file. 2. Add `@kevingurney` and `@sgilmore10` as `CODEOWNERS` for file `.github/workflows/matlab.yml`. Co-authored-by: Sarah Gilmore <sgilmore@mathworks.com>
kevingurney
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
|
Note: @kou - The changes in this PR were adapted from the diff you shared in #49811 (comment). Since there was no explicit license included with this diff, please let us know if you have any concerns regarding the use of this adapted code from a copyright perspective. |
github-actions
Bot
added
awaiting merge
|
+1 |
|
Before I proceed with merging this, @kou do you have any flags regarding my previous comment? |
There was a problem hiding this comment.
Pull request overview
Reorganizes .github/CODEOWNERS to be more readable by grouping paths under component headers, and updates ownership for the MATLAB CI workflow file.
Changes:
- Group CODEOWNERS entries under component comment headers (C GLib, C++, MATLAB, Python, R, Ruby).
- Add MATLAB maintainers as CODEOWNERS for
.github/workflows/matlab.yml. - Move R packaging-tooling patterns into the R section.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /matlab/ @kevingurney @kou @sgilmore10 | ||
| /.github/workflows/matlab.yml @kevingurney @sgilmore10 |
There was a problem hiding this comment.
/.github/workflows/matlab.yml is currently listed before the broader /.github/ ... rule later in the file. In CODEOWNERS, the last matching pattern wins, so the later /.github/ entry will override this and the MATLAB-specific owners won't be applied. Move the /.github/workflows/matlab.yml rule below the /.github/ rule (or otherwise narrow the /.github/ rule) so it takes precedence for that file.
| ## Components | ||
| # Components | ||
|
|
||
| ## C Glib |
There was a problem hiding this comment.
Component header uses C Glib, but the project consistently refers to this component as C GLib (e.g., .github/workflows/ruby.yml and r/_pkgdown.yml). Consider updating the header capitalization for consistency and searchability.
| ## C Glib | |
| ## C GLib |
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
No problem! We can use the diff under Apache-2.0 by the ASF!
| /matlab/ @kevingurney @kou @sgilmore10 | ||
| /.github/workflows/matlab.yml @kevingurney @sgilmore10 |
There was a problem hiding this comment.
Sort.
| /matlab/ @kevingurney @kou @sgilmore10 | |
| /.github/workflows/matlab.yml @kevingurney @sgilmore10 | |
| /.github/workflows/matlab.yml @kevingurney @sgilmore10 | |
| /matlab/ @kevingurney @kou @sgilmore10 |
github-actions
Bot
added
awaiting changes
| ## Components | ||
| # Components | ||
|
|
||
| ## C Glib |
There was a problem hiding this comment.
Hmm. I don't know why the suggested change by Copilot can't be applied...
| ## C Glib | |
| ## C GLib |
There was a problem hiding this comment.
Ah, I can't push to https://github.com/mathworks/arrow .
Rationale for this change
Based on the feedback shared by @kou in #49811 (comment), we should consider grouping files under component comment headers in
.github/CODEOWNERSto improve readability.We should also add
@kevingurneyand@sgilmore10asCODEOWNERSfor the MATLAB-related CI file.github/workflows/matlab.yml.Component(s)
Developer Tools
What changes are included in this PR?
.github/CODEOWNERSfile.@kevingurneyand@sgilmore10asCODEOWNERSfor file.github/workflows/matlab.yml.Are these changes tested?
N/A.
Are there any user-facing changes?
No.
Notes
.github/CODEOWNERS#49890