Skip to content

GH-48294: [Ruby] Add RecordBatch#merge#50175

Merged
kou merged 1 commit into
apache:mainfrom
Reranko05:add-record-batch-merge
Jun 17, 2026
Merged

GH-48294: [Ruby] Add RecordBatch#merge#50175
kou merged 1 commit into
apache:mainfrom
Reranko05:add-record-batch-merge

Conversation

@Reranko05

@Reranko05 Reranko05 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

This adds Arrow::RecordBatch#merge with behavior analogous to
Arrow::Table#merge.

What changes are included in this PR?

  • Add RecordBatch#merge
  • Support merging with a Hash
  • Support merging with another RecordBatch
  • Support column addition, replacement, and removal (via Hash values of nil)
  • Add tests covering the new behavior

Are these changes tested?

Yes. Added unit tests covering:

  • add column
  • remove column
  • replace column
  • merge with another RecordBatch
  • invalid merge target

Copilot AI review requested due to automatic review settings June 15, 2026 10:59
@Reranko05 Reranko05 requested a review from kou as a code owner June 15, 2026 10:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #48294 has been automatically assigned in GitHub to PR creator.

@kou kou changed the title GH-48294: Add RecordBatch#merge GH-48294: [Ruby] Add RecordBatch#merge Jun 17, 2026
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #48294 has been automatically assigned in GitHub to PR creator.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Could you unify common code in Table#merge and RecordBatch#merge to ColumnContainable#merge as a follow-up task?

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 17, 2026
@kou kou merged commit e6146ee into apache:main Jun 17, 2026
14 checks passed
@kou kou removed the awaiting merge Awaiting merge label Jun 17, 2026
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e6146ee.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants