GH-50901: [C++] Replace RapidJSON with simdjson in tensor extension types - #50874
Open
Reranko05 wants to merge 5 commits into
Open
GH-50901: [C++] Replace RapidJSON with simdjson in tensor extension types#50874Reranko05 wants to merge 5 commits into
Reranko05 wants to merge 5 commits into
Conversation
|
Thanks for opening a pull request! This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format. If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or After updating the title, you can mark the pull request as ready for review. See also: |
Reranko05
changed the title
Reranko05
marked this pull request as ready for review
August 18, 2026 10:57
kou
reviewed
Aug 18, 2026
github-actions
Bot
added
awaiting changes
github-actions
Bot
added
awaiting change review
rok
reviewed
Aug 19, 2026
github-actions
Bot
added
awaiting changes
kou
reviewed
Aug 19, 2026
github-actions
Bot
added
awaiting change review
kou
reviewed
Aug 20, 2026
github-actions
Bot
added
awaiting changes
Reranko05
force-pushed
the
gh-35460-extension
branch
from
August 20, 2026 08:52
dd55d0b to
298964c
Compare
github-actions
Bot
added
awaiting change review
Reranko05
force-pushed
the
gh-35460-extension
branch
from
August 20, 2026 09:02
298964c to
ac194ba
Compare
Reranko05
force-pushed
the
gh-35460-extension
branch
from
August 20, 2026 09:06
ac194ba to
069be12
Compare
kou
reviewed
Aug 20, 2026
Comment on lines
+251
to
+253
| if (type == simdjson::ondemand::json_type::unknown) { | ||
| return Status::Invalid("Invalid serialized JSON data: ", serialized_data); | ||
| } |
Member
There was a problem hiding this comment.
Can we remove this check? It seems that this is redundant.
Collaborator
Author
There was a problem hiding this comment.
I tried removing it, but value.type() can successfully return json_type::unknown for malformed input such as {"shape":(3,4)}. Without this check, the error becomes shape must be an array, got unknown instead of the expected invalid JSON error, so I think we need to keep it.
github-actions
Bot
added
awaiting changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR continues the simdjson migration by replacing RapidJSON usage in the
FixedShapeTensorTypeandVariableShapeTensorTypeextension types with the existing simdjson helpers and On-Demand API.Changes
FixedShapeTensorType::Deserializewith simdjson.VariableShapeTensorType::Deserializewith simdjson.JsonTypeNamehelper from the tensor extension utilities.Fixes: #50901