AVRO-4185: [C++] Use a temp file in StreamTests#3496
Open
gahr wants to merge 2 commits intoapache:mainfrom
Open
AVRO-4185: [C++] Use a temp file in StreamTests#3496gahr wants to merge 2 commits intoapache:mainfrom
gahr wants to merge 2 commits intoapache:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
StreamTests uses the test_str.bin file. This is problematic in our setup because we build and test 32-bit and 64-bit versions in parallel. When the 32-bit and 64-bit StreamTest happen to run concurrently, one ends up deleting the file that the other is trying to read.
My solution here is to use a temporary file instead of the hard-coded test_str.bin.
This fixes AVRO-4185.
Verifying this change
This change is already covered by existing tests, such as StreamTests.
Documentation