Skip to content

Comments

Add a configuration to wait for session creation#37625

Open
sakthivelmanii wants to merge 8 commits intoapache:masterfrom
sakthivelmanii:add_option_set_wait_for_mux
Open

Add a configuration to wait for session creation#37625
sakthivelmanii wants to merge 8 commits intoapache:masterfrom
sakthivelmanii:add_option_set_wait_for_mux

Conversation

@sakthivelmanii
Copy link
Contributor

Please add a meaningful description for your change here

We will providing an option to the templates to set a minimum time to wait for session before throwing an error. It also retry the session creation for the duration.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sakthivelmanii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Spanner I/O connector by providing a new configuration to manage the initial setup of Spanner sessions. It allows users to specify a duration for which the system should wait and retry session creation, thereby improving the robustness and resilience of applications connecting to Google Cloud Spanner, especially in environments where session availability might be delayed.

Highlights

  • New Configuration Option: Introduced a new configuration option, waitForSessionCreationDuration, in SpannerConfig to allow users to specify how long to wait for a Spanner session to be created.
  • Session Pool Configuration: Implemented the use of the new waitForSessionCreationDuration in SpannerAccessor to configure the SessionPoolOptions for Spanner connections, enabling a retry mechanism during session creation.
  • Default Wait Duration: Defined a default wait duration of 5 minutes for session creation if no specific duration is provided by the user.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
    • Imported necessary classes for SessionPoolOptions and Optional.
    • Added a static final DEFAULT_SESSION_WAIT_DURATION constant.
    • Modified the buildSpannerOptions method to retrieve the waitForSessionCreationDuration from SpannerConfig and apply it to the SessionPoolOptions builder.
  • sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java
    • Added an abstract getter method getWaitForSessionCreationDuration().
    • Added an abstract builder setter method setWaitForSessionCreationDuration().
    • Introduced public withWaitForSessionCreationDuration() methods (overloaded for ValueProvider and java.time.Duration) with Javadoc for setting the new configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @kennknowles for label java.
R: @nielm for label spanner.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant