Add OrderedListState support in Go SDK#37629
Add OrderedListState support in Go SDK#37629hnnsgstfssn wants to merge 7 commits intoapache:masterfrom
Conversation
Summary of ChangesHello @hnnsgstfssn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Apache Beam Go SDK by introducing Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers: R: @lostluck for label go. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
@shunping could you take a look at this one? |
The Go SDK stateful DoFn API was missing OrderedListState, the only state type already supported in Java and Python but absent from the Go plumbing. This adds the missing pieces. - state.OrderedList[T] with Add, Read, ReadRange, Clear, ClearRange operating on int64 sort keys - Provider interface wired through exec, graphx translate, and the harness state manager to the Fn API beam:coder:ordered_list_state:v1 URN - Unit tests (state, userstate, sideinput) and integration tests against the prism runner Relates to the following issues. - apache#20510 tracking issue for Go SDK state & timer support (closed, but ordered list was not included) - apache#22736 the original "Implement State in Go" task (closed with Value/Bag/Combining only) - apache#18493 open, tracks full portable user state coverage including ordered list - apache#25894 open, composite state proposal that explicitly depends on ordered list as a primitive
Documentation snippet in the programming guide, standalone example pipeline, and CHANGES.md entry.
0fbc959 to
8fc6255
Compare
lostluck
left a comment
There was a problem hiding this comment.
Seems fairly reasonable on a quick pass at least. Just one naming nit.
I like the clear framing that the sort key can be a millisecond time representation, but doesn't have to be. Outside of overloads or a 2nd method, this is preferable to forcing users to get their sort keys represented as time.Time for us to interpret.
OrderedListValue will make the connection to the state type clearer, since it is largely referencing the sort key as a generic sort key.
Since the is no clear issue for this particular change, the PR is referenced instead.
Add back a ) that was dropped, prefix with (Go) following existing entries and put directly after existing entries.
The Go SDK stateful DoFn API was missing OrderedListState, the only
state type already supported in Java and Python but absent from the Go
plumbing. This adds the missing pieces.
operating on int64 sort keys
harness state manager to the Fn API beam:coder:ordered_list_state:v1
URN
the prism runner
Relates to the following issues.
(closed, but ordered list was not included)
Value/Bag/Combining only)
ordered list
ordered list as a primitive
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.