Skip to content

Comments

Unpin grpc.#37633

Open
tvalentyn wants to merge 1 commit intoapache:masterfrom
tvalentyn:grpc
Open

Unpin grpc.#37633
tvalentyn wants to merge 1 commit intoapache:masterfrom
tvalentyn:grpc

Conversation

@tvalentyn
Copy link
Contributor

We expect that grpc 1.78.1 fixes grpc/grpc#37710, so we'd like to remove the pin we have.

fixes: #34081


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tvalentyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adjusts the grpcio dependency specifications within setup.py. The changes aim to refine the allowed grpcio versions, particularly by adding more specific exclusions for Python 3.12 and earlier, and setting an upper bound for Python 3.13+. This is a preparatory step towards fully unpinning grpcio once version 1.78.1, which is expected to resolve a known issue, is released and stable.

Highlights

  • Updated grpcio dependency constraints: Modified the grpcio version requirements in setup.py to exclude a wider range of problematic versions (1.66.* through 1.78.0) for Python versions up to 3.12, and added an upper bound of <2 for Python 3.13 and above.
  • Revised TODO comment: Updated the TODO comment related to grpcio pinning to reflect the ongoing effort to consolidate version bounds once grpcio 1.78.1 becomes available.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/python/setup.py
    • Updated grpcio dependency specification to include more exclusions for Python <= 3.12.
    • Added an upper bound for grpcio dependency for Python >= 3.13.
    • Modified the TODO comment regarding grpcio pinning to reflect future consolidation.
Activity
  • No specific activity (comments, reviews, progress) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tvalentyn
Copy link
Contributor Author

R: @potiuk @damccorm @Amar3tto

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@damccorm damccorm added this to the 2.72.0 Release milestone Feb 18, 2026
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one minor comment, but generally LGTM

@tvalentyn
Copy link
Contributor Author

it looks like some tests fail with dependency resolution issues; it might change once 1.78.1 becomes officially released

Copy link
Member

@gopidesupavan gopidesupavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tvalentyn

@tvalentyn
Copy link
Contributor Author

patch release is out, reopening the pr to trigger all test rerun.

@tvalentyn tvalentyn closed this Feb 20, 2026
@tvalentyn tvalentyn reopened this Feb 20, 2026
@gopidesupavan
Copy link
Member

cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: gprcio limitation to < 1.66 in Python is problematic [Python] Significant test flakiness after upgrading to grpcio 1.66.0

4 participants