fix: allow union types in streaming_action.pydantic stream_type parameter#732
Open
mvanhorn wants to merge 1 commit intoapache:mainfrom
Open
fix: allow union types in streaming_action.pydantic stream_type parameter#732mvanhorn wants to merge 1 commit intoapache:mainfrom
mvanhorn wants to merge 1 commit intoapache:mainfrom
Conversation
…eter Accept types.UnionType in stream_type so Python 3.10+ union syntax (MyModel1 | MyModel2) works with streaming_action.pydantic decorator. Fixes apache#607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.10+ union syntax (
MyModel1 | MyModel2) creates atypes.UnionType, which thestream_typeparameter rejected because it only acceptedType[BaseModel]orType[dict].Added
types.UnionTypeto the accepted types in three places:burr/integrations/pydantic.py:PartialTypealias (line 272)burr/integrations/pydantic.py:_validate_and_extract_signature_types_streamingparameter (line 293)burr/core/action.py:streaming_action.pydanticparameter (line 1514)Before:
After:
Both files already import
types, so no new imports needed.types.UnionTypeis available in Python 3.10+; on 3.9, the|syntax isn't available anyway so the added type is inert.Fixes #607
This contribution was developed with AI assistance (Claude Code).