[CALCITE-6135] BEARER authentication support#232
Conversation
|
|
||
| import java.io.IOException; | ||
|
|
||
| public class SingleBearerTokenProvider implements BearerTokenProvider { |
There was a problem hiding this comment.
That name sounds off. Every provider provides a single token (at a time).
Wouldn't SimpleBearerTokenProvider be more descriptive ?
There was a problem hiding this comment.
This object can provide a single token for its entire lifetime. Maybe Constant?
I'd avoid "Simple" as it may sound that the token is simple in some way.
|
Can you open a [DISCUSS] thread on the calcite list about this change ? |
|
@stoty Based on your suggestion on the devlist, token providers now can be plugged in via config properties. Users can define their custom properties and use it in token provider's init function. There's a very basic example in the tests. |
|
For the record: Either to 5.5, which is hopefully going to a have a new SPNEGO implementation, or to 5.4, and re-enable the deprecated SPENGO authentication in it.. |
|
This needs heavy refactoring, now that we have updated httpclient to one which has native BEARER support. |
c7cee40 to
a9dc6f8
Compare
No description provided.