chore: refine OSS helper rules, add attribution requirements#24254
Conversation
|
Do we have something about that any kind of coding assistance MUST be co signed in the commit message. Co-authored by a coding agent, or whatever they do. We need this from ASF to track what is AI assisted vs what is not. Here is an example that is good |
85266ec to
2d08d8b
Compare
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
@davsclaus I think this is a configuration on the coding agent itself. I know Claude allows you to set a configuration like this in the settings file: |
|
🧪 CI tested the following changed modules:
|
|
okay but if we add to the rules/skills files that the commit message must contain a "co-authored by AI" or similar to signal its AI assisted. |
oscerd
left a comment
There was a problem hiding this comment.
in the harness organization, I think we should remove the project when we merge the rules in the upstream.
|
It's already merged, we are just refining them here. I think what we had there isn't really what people have been using. So, this should help consolidate |
To be honest, I'm not entirely sure what is your expectation here because we already have that in the AGENTS.md file. Can you elaborate, please? |
Where is it in AGENTS.md file? I cannot see that. Today we have contributions from users where the commit message does not indicate it was AI assisted. |
|
"All AI-generated content (GitHub PR descriptions, review comments, JIRA comments) MUST clearly identify itself as AI-generated and mention the human operator. Example: "Claude Code on behalf of [Human Name]" We have this. We also have some commit guidelines at the end of that file, but they don't request for you are asking about. |
Its not precise we still end up with commits without that. Add commit messages to that list All AI-generated content (commit messages, GitHub PR descriptions, review comments, JIRA comments, etc.) MUST |
|
I get it ... That's why it is set as a configuration on the agents configuration itself. Adding it here would just polute the context and duplicate the same rule from Agents |
|
LGTM |
Summary
Claude Code on behalf of Otavio Rodolfo Piske
Follow-up to #24251 — addresses review feedback and adds attribution requirements for AI-assisted contributions.
Changes
mvn -Dquickly install(fast build, tests covered by separate test command)AGENTS.mdto require co-authorship trailers on commits (e.g.,Co-authored-by)Test plan
mvn -Dquickly installinproject-standards.mdAGENTS.mdincludes co-authorship trailer requirement