Skip to content

chore: refine OSS helper rules, add attribution requirements#24254

Merged
davsclaus merged 2 commits into
apache:mainfrom
orpiske:quick-fix/refine-oss-helper-rules
Jun 26, 2026
Merged

chore: refine OSS helper rules, add attribution requirements#24254
davsclaus merged 2 commits into
apache:mainfrom
orpiske:quick-fix/refine-oss-helper-rules

Conversation

@orpiske

@orpiske orpiske commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Claude Code on behalf of Otavio Rodolfo Piske

Follow-up to #24251 — addresses review feedback and adds attribution requirements for AI-assisted contributions.

Changes

  • Build command: use mvn -Dquickly install (fast build, tests covered by separate test command)
  • Parallelized Maven: allow parallel builds (except test execution)
  • Records code style rule: "Records are allowed for internal/non-API classes; do NOT convert existing public API classes to Records"
  • CLAUDE.md → .oss-ai-helper-rules pointer: added reference in the Build section to reduce overlap/drift
  • Attribution requirements:
    • Updated AGENTS.md to require co-authorship trailers on commits (e.g., Co-authored-by)
    • Added attribution subsection to the contributing guide with a link to Claude Code's attribution settings as an example
    • Added AI attribution checkbox to the PR template

Test plan

  • Verify build command is mvn -Dquickly install in project-standards.md
  • Verify parallelized Maven is set to yes
  • Verify Records rule is present in code style restrictions
  • Verify AGENTS.md includes co-authorship trailer requirement
  • Verify contributing guide has attribution subsection
  • Verify PR template has AI attribution checkbox

@orpiske orpiske requested review from davsclaus and oscerd June 25, 2026 14:17
@davsclaus

Copy link
Copy Markdown
Contributor

Do we have something about that any kind of coding assistance MUST be co signed in the commit message.

Co-authored by a coding agent, or whatever they do.

We need this from ASF to track what is AI assisted vs what is not.

Here is an example that is good

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@orpiske orpiske force-pushed the quick-fix/refine-oss-helper-rules branch from 85266ec to 2d08d8b Compare June 25, 2026 14:24
@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions github-actions Bot added the docs label Jun 25, 2026
@orpiske

orpiske commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@davsclaus I think this is a configuration on the coding agent itself. I know Claude allows you to set a configuration like this in the settings file:

"attribution": {
    "commit": "... something something",
    "pr": "... something something"
  },

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • docs

⚙️ View full build and test results

@davsclaus

Copy link
Copy Markdown
Contributor

okay but if we add to the rules/skills files that the commit message must contain a "co-authored by AI" or similar to signal its AI assisted.

Comment thread .oss-ai-helper-rules/project-standards.md Outdated

@oscerd oscerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the harness organization, I think we should remove the project when we merge the rules in the upstream.

@orpiske

orpiske commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

It's already merged, we are just refining them here. I think what we had there isn't really what people have been using. So, this should help consolidate

@orpiske

orpiske commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Do we have something about that any kind of coding assistance MUST be co signed in the commit message.

Co-authored by a coding agent, or whatever they do.

We need this from ASF to track what is AI assisted vs what is not.

Here is an example that is good


Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

To be honest, I'm not entirely sure what is your expectation here because we already have that in the AGENTS.md file.

Can you elaborate, please?

@davsclaus

Copy link
Copy Markdown
Contributor

Do we have something about that any kind of coding assistance MUST be co signed in the commit message.
Co-authored by a coding agent, or whatever they do.
We need this from ASF to track what is AI assisted vs what is not.
Here is an example that is good


Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

To be honest, I'm not entirely sure what is your expectation here because we already have that in the AGENTS.md file.

Can you elaborate, please?

Where is it in AGENTS.md file? I cannot see that.

Today we have contributions from users where the commit message does not indicate it was AI assisted.

@orpiske

orpiske commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

"All AI-generated content (GitHub PR descriptions, review comments, JIRA comments) MUST clearly identify itself as AI-generated and mention the human operator. Example: "Claude Code on behalf of [Human Name]"

We have this.

We also have some commit guidelines at the end of that file, but they don't request for you are asking about.

@davsclaus

Copy link
Copy Markdown
Contributor

"All AI-generated content (GitHub PR descriptions, review comments, JIRA comments) MUST clearly identify itself as AI-generated and mention the human operator. Example: "Claude Code on behalf of [Human Name]"

We have this.

We also have some commit guidelines at the end of that file, but they don't request for you are asking about.

Its not precise we still end up with commits without that. Add commit messages to that list

All AI-generated content (commit messages, GitHub PR descriptions, review comments, JIRA comments, etc.) MUST

Comment thread .oss-ai-helper-rules/project-standards.md Outdated
@orpiske

orpiske commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

I get it ... That's why it is set as a configuration on the agents configuration itself. Adding it here would just polute the context and duplicate the same rule from Agents

@orpiske orpiske changed the title chore: refine OSS helper rules and point CLAUDE.md to them chore: refine OSS helper rules, add attribution requirements Jun 26, 2026
@orpiske orpiske requested a review from jamesnetherton June 26, 2026 07:44
@davsclaus

Copy link
Copy Markdown
Contributor

LGTM

@davsclaus davsclaus merged commit 1073e0c into apache:main Jun 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants