[backport camel-4.18.x] CAMEL-23840: Fix pollEnrich cacheSize(-1) not disabling consumer cache#24285
Merged
Merged
Conversation
pollEnrich().cacheSize(-1) should disable the consumer cache entirely, but DefaultConsumerCache normalizes cacheSize <= 0 to the context maximum (default 1000), retaining up to 1000 polling consumers. For resource-backed components like SFTP, each retained consumer holds an open connection that is never cleaned up. Fix by introducing EmptyConsumerCache (mirroring EmptyProducerCache) that creates a fresh consumer on every acquire and stops it on release. PollEnricher.doBuild() now selects EmptyConsumerCache when cacheSize < 0, matching the pattern used by SendDynamicProcessor, RecipientList, and RoutingSlip on the producer side. Closes #24283 Co-Authored-By: OpenCode (DeepSeek V4 Pro) <contact@anoma.ly> Co-Authored-By: OpenCode (GLM 5.2) <contact@anoma.ly>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24283
Cherry-pick of #24283 onto
camel-4.18.x.Original PR: #24283 - CAMEL-23840: camel-core: pollEnrich with cacheSize(-1) does not disable consumer cache (dynamic endpoints)
Original author: @msnijder30
Target branch:
camel-4.18.xOriginal description
pollEnrich().cacheSize(-1) is documented to disable the consumer cache entirely, but DefaultConsumerCache normalizes cacheSize <= 0 to the CamelContext maximum (default 1000), retaining up to 1000 polling consumers. For resource-backed components (e.g., SFTP), each retained consumer holds an open connection that is never cleaned up.
Fix introduces EmptyConsumerCache (mirroring EmptyProducerCache) that creates a fresh consumer on every acquire and stops it on release. PollEnricher.doBuild() now selects EmptyConsumerCache when cacheSize < 0, matching the pattern used by SendDynamicProcessor, RecipientList, and RoutingSlip on the producer side.
See original PR for full details.