CLOUDSTACK-10269: On deletion of role set name to null

[yadvr]

During deletion of role, set name to null. This fixes concurrent
exception issue where previously it would rename the deleted role
with a timestamp.

Pinging for review - @DaanHoogland @nvazquez @borisstoyanov and others.

@blueorangutan package

[yadvr]

Roles related tests pass:

Test to ensure 4 default roles cannot be deleted ... === TestName: test_default_role_deletion | Status : SUCCESS ===
ok
Test to check role, role permissions and account life cycles ... === TestName: test_role_account_acls | Status : SUCCESS ===
ok
Test for role-rule enforcement in case of multiple mgmt servers ... === TestName: test_role_account_acls_multiple_mgmt_servers | Status : SUCCESS ===
ok
Test to ensure role in use cannot be deleted ... === TestName: test_role_inuse_deletion | Status : SUCCESS ===
ok
Tests normal lifecycle operations for roles ... === TestName: test_role_lifecycle_create | Status : SUCCESS ===
ok
Tests role update ... === TestName: test_role_lifecycle_delete | Status : SUCCESS ===
ok
Tests that default four roles exist ... === TestName: test_role_lifecycle_list | Status : SUCCESS ===
ok
Tests role update ... === TestName: test_role_lifecycle_update | Status : SUCCESS ===
ok
Tests role update when role is in use by an account ... === TestName: test_role_lifecycle_update_role_inuse | Status : SUCCESS ===
ok
Tests concurrent order updation of role permission ... === TestName: test_rolepermission_lifecycle_concurrent_updates | Status : SUCCESS ===
ok
Tests creation of role permission ... === TestName: test_rolepermission_lifecycle_create | Status : SUCCESS ===
ok
Tests deletion of role permission ... === TestName: test_rolepermission_lifecycle_delete | Status : SUCCESS ===
ok
Tests listing of default role's permission ... === TestName: test_rolepermission_lifecycle_list | Status : SUCCESS ===
ok
Tests order updation of role permission ... === TestName: test_rolepermission_lifecycle_update | Status : SUCCESS ===
ok
Tests update of Allow to Deny permission of a rule ... === TestName: test_rolepermission_lifecycle_update_permission | Status : SUCCESS ===
ok
Tests negative test for setting incorrect value as permission ... === TestName: test_rolepermission_lifecycle_update_permission_negative | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 16 tests in 33.095s

[blueorangutan]

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[DaanHoogland]

code seems to do what it says

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1692

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-2240)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27361 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2444-t2240-kvm-centos7.zip
Smoke tests completed. 67 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[borisstoyanov]

LGTM