Skip to content

CLOUDSTACK-10303 : test data to nuage_test_data.py + run all tests against simulator - #2483

Merged
yadvr merged 9 commits into
apache:4.11from
nuagenetworks:feature/move_test_data
Mar 14, 2018
Merged

CLOUDSTACK-10303 : test data to nuage_test_data.py + run all tests against simulator#2483
yadvr merged 9 commits into
apache:4.11from
nuagenetworks:feature/move_test_data

Conversation

@smeetsr

@smeetsr smeetsr commented Mar 12, 2018

Copy link
Copy Markdown
Contributor

No description provided.

Sigert Goeminne and others added 8 commits February 28, 2018 10:57
@smeetsr

smeetsr commented Mar 12, 2018

Copy link
Copy Markdown
Contributor Author

All tests in test/integration/plugins/nuagevsp have been executed for simulator See
results.txt
and also on testbed with KVM hypervisors.

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big PR but looks fine.

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1771

@krissterckx krissterckx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This addresses CLOUDSTACK-10219 also which i set up based on earlier @rhtyd review.

@fmaximus fmaximus added this to the 4.11.1 milestone Mar 14, 2018
@fmaximus

Copy link
Copy Markdown
Contributor

@DaanHoogland Thanks for the review
Can we merge, or do we need CI?
All changes are in either Simulator, or our marvin tests,
so technically, running smoke isn't impacted.

@yadvr yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yadvr

yadvr commented Mar 14, 2018

Copy link
Copy Markdown
Member

Given all the changes are nuage specific tests related, and simulator has passed no additional integration testing is needed. We don't have nuage h/w to test this, will merge based on simular/travis test results and reviews, and test results shared on this PR.

@yadvr
yadvr merged commit 19d6578 into apache:4.11 Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants