CLOUDSTACK-10330 PULL_REQUEST_TEMPLATE: Add pull request template - #2489
Conversation
This adds a pull request template. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✖debian. JID-1780 |
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
looks fine, let's take it from here
nvazquez
left a comment
nvazquez
left a comment
There was a problem hiding this comment.
I would remove the blueorangutan packaging job as in many cases it can be invoked but will perform no action if the user is not on its allowed list
|
Thanks Nicolas, bo pkg can be requested by anyone on apache/cloudstack repo. But only authorized users can run tests. |
|
Sorry, thought packaging too. Then LGTM as it is |
| ## Checklist: | ||
| <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> | ||
| <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> | ||
| - [ ] I have read the **CONTRIBUTING** document. |
There was a problem hiding this comment.
It would be nice to hyperlink the "CONTRIBUTING" text.
rafaelweingartner
left a comment
rafaelweingartner
left a comment
There was a problem hiding this comment.
That is a great initiative! Congratulations @rhtyd!
It is looking very nice this template. big 👍
| - [ ] Bug fix (non-breaking change which fixes an issue) | ||
| - [ ] New feature (non-breaking change which adds functionality) | ||
| - [ ] Breaking change (fix or feature that would cause existing functionality to change) | ||
|
|
There was a problem hiding this comment.
I think we can have "improvement" and/or "enhancement" here too, because there could be a case which the PR falls on neither of above because of the two mentioned states.
There was a problem hiding this comment.
Also, what about code cleanup and PRs, which only add test cases?
There was a problem hiding this comment.
Correct! Those two make sense as well.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr
changed the title
|
This is simply doc change, merging this based on feedback (incorporated) and 2+ reviews. |
6 participants
This adds a pull request template. That would look like below:
Description
This adds a pull request for future CloudStack PRs.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Tested on Github.
Checklist:
@blueorangutan package