build: change default Maven profile to Spark 4.0 / Scala 2.13#4140
Open
andygrove wants to merge 4 commits intoapache:mainfrom
Open
build: change default Maven profile to Spark 4.0 / Scala 2.13#4140andygrove wants to merge 4 commits intoapache:mainfrom
andygrove wants to merge 4 commits intoapache:mainfrom
Conversation
Update the default build configuration from Spark 3.5 / Scala 2.12 to Spark 4.0 / Scala 2.13. The spark-3.4 and spark-3.5 profiles now explicitly set scala.binary.version, shims.majorVerSrc, and semanticdb.version since those defaults have changed. The scala-2.12 profile is populated and scala-2.13 is now empty (matching defaults). Also updates Dockerfile, Docker publish workflow, and all documentation to reflect the new defaults. Co-Authored-By: Claude Opus 4.6 <[email protected]>
…K to 17 The scala-2.13 profile must retain its properties so that `-Pspark-3.x -Pscala-2.13` correctly overrides the Spark profile's scala.binary.version=2.12. Without this, Iceberg CI builds produce _2.12 artifacts when _2.13 is expected. The TPC-DS/TPC-H verification jobs used JDK 11 with no explicit Spark profile, so they now inherit the Spark 4.0 default which requires JDK 17. Co-Authored-By: Claude Opus 4.6 <[email protected]>
The spark/pom.xml Iceberg dependency profiles use activeByDefault to provide the right Iceberg version when no -Pspark-* is passed. Since the default is now Spark 4.0, the activeByDefault must be on the spark-4.0 profile (Iceberg 1.10.0) rather than spark-3.5 (Iceberg 1.8.1), otherwise Maven resolves the non-existent artifact iceberg-spark-runtime-4.0_2.13:1.8.1. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spark-3.4andspark-3.5profiles to explicitly setscala.binary.version=2.12,shims.majorVerSrc=spark-3.x, andsemanticdb.version=4.8.8(previously inherited from defaults)scala-2.12profile with explicit properties and emptiesscala-2.13(now matches defaults)spark-4.0profileWhich issue does this PR close?
N/A
Test plan
./mvnw compile -pl common -DskipTestsbuilds with Spark 4.0 by default./mvnw compile -pl common -DskipTests -Pspark-3.5still builds with Spark 3.5./mvnw compile -pl common -DskipTests -Pspark-3.4still builds with Spark 3.4🤖 Generated with Claude Code