Skip to content

Implement core::error::Error for ParserError and TokenizerError #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iffyio merged 2 commits into from
Feb 2, 2026
+3 −6
Merged

Implement core::error::Error for ParserError and TokenizerError #2189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e0c93e
Now always implementing core error instead of std erro
LucaCappelletti94 Feb 1, 2026
95781ce
Removed other instances where std Error was implemented instead of co…
LucaCappelletti94 Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/parser/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,7 @@ impl fmt::Display for ParserError {
}
}

#[cfg(feature = "std")]
impl std::error::Error for ParserError {}
impl core::error::Error for ParserError {}

// By default, allow expressions up to this deep before erroring
const DEFAULT_REMAINING_DEPTH: usize = 50;
Expand Down
6 changes: 2 additions & 4 deletions src/tokenizer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,8 +782,7 @@ impl fmt::Display for TokenizerError {
}
}

#[cfg(feature = "std")]
impl std::error::Error for TokenizerError {}
impl core::error::Error for TokenizerError {}

struct State<'a> {
peekable: Peekable<Chars<'a>>,
Expand Down Expand Up @@ -2554,9 +2553,8 @@ mod tests {
message: "test".into(),
location: Location { line: 1, column: 1 },
};
#[cfg(feature = "std")]
{
use std::error::Error;
use core::error::Error;
assert!(err.source().is_none());
}
assert_eq!(err.to_string(), "test at Line: 1, Column: 1");
Expand Down
Loading