Skip to content

Preserve numeric compound field access display #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LucaCappelletti94 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Preserve numeric compound field access display #2463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/ast/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1487,6 +1487,9 @@ pub enum AccessExpr {
impl fmt::Display for AccessExpr {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
AccessExpr::Dot(Expr::Value(value)) if matches!(value.value, Value::Number(_, _)) => {
write!(f, " . {value}")
}
AccessExpr::Dot(expr) => write!(f, ".{expr}"),
AccessExpr::Subscript(subscript) => write!(f, "[{subscript}]"),
}
Expand Down
11 changes: 11 additions & 0 deletions tests/sqlparser_postgres.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9852,3 +9852,14 @@ fn parse_alter_table_constraint_check_no_inherit() {
}
pg_and_generic().verified_stmt("ALTER TABLE docs ADD CONSTRAINT c CHECK (id > 0) NO INHERIT");
}

#[test]
fn parse_compound_field_access_numeric_display() {
let sql = "SELECT * FROM t WHERE CASE WHEN a = 1 THEN b ELSE c END . 2";
let mut statements = pg().parse_sql_statements(sql).unwrap();
assert_eq!(statements.len(), 1);
let statement = statements.pop().unwrap();
let displayed = statement.to_string();
let reparsed = pg().parse_sql_statements(&displayed).unwrap();
assert_eq!(vec![statement], reparsed);
}
Loading