Adjust case_when DivideByZeroProtection benchmark so that "percentage of zeroes" corresponds to "number of times protection is needed"#20105
Merged
alamb merged 2 commits intoapache:mainfrom Feb 2, 2026
Conversation
…" corresponds to "number of times protection is needed"
alamb
approved these changes
Feb 2, 2026
Contributor
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me -- thank you @pepijnve
fyi @CuteChuanChuan
Contributor
|
Merging this in so I can re-run the benchmarks on #19994 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The
case_whenmicrobenchmark that covers the patternCASE WHEN d != 0 THEN n / d ELSE NULL ENDpattern is parameterised over the percentage of zeroes in thedcolumn. The benchmark uses the conditiond > 0rather thand != 0though which is a bit misleading. In the '0% zeroes' run one would expect the else branch to never be taken, but because slightly less than 50% of thedvalues is negative, it's still taken 50% of the time.This PR adjust the benchmark to use
d != 0instead.What changes are included in this PR?
d != 0as conditionCASEpatternAre these changes tested?
Manual testing
Are there any user-facing changes?
No