Optimize regexp_replace by stripping trailing .* from anchored patterns. 2.4x improvement#21379
Open
Dandandan wants to merge 8 commits intoapache:mainfrom
Open
Optimize regexp_replace by stripping trailing .* from anchored patterns. 2.4x improvement#21379Dandandan wants to merge 8 commits intoapache:mainfrom
Dandandan wants to merge 8 commits intoapache:mainfrom
Conversation
For anchored patterns like `^prefix(capture)/.*$`, use regex-syntax HIR analysis to build a shorter regex without the trailing `.*`. Uses captures() + expand() on the shorter regex instead of replacen(), since the replacement replaces the entire string (original was ^...$) and we only need correct capture group positions. For ClickBench Q28's `^https?://(?:www\.)?([^/]+)/.*$`, the effective regex becomes `^https?://(?:www\.)?([^/]+)/` — the backtracker stops at the first `/` after the domain instead of scanning the full URL. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
sqllogictest
Contributor
Author
|
run benchmarks |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing optimize-regexp-replace-v2 (62046ab) to c17c87c (merge-base) diff using: tpch File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing optimize-regexp-replace-v2 (62046ab) to c17c87c (merge-base) diff using: tpcds File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing optimize-regexp-replace-v2 (62046ab) to c17c87c (merge-base) diff using: clickbench_partitioned File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
Contributor
Author
|
run benchmarks |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing optimize-regexp-replace-v2 (61e3663) to c17c87c (merge-base) diff using: clickbench_partitioned File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing optimize-regexp-replace-v2 (ab44f24) to c17c87c (merge-base) diff using: tpcds File an issue against this benchmark runner |
Split anchored ^prefix(capture)suffix.*$ patterns into separate prefix and content regexes (no capture groups). Uses two find() calls instead of captures() + expand(), avoiding capture-group tracking overhead and String allocation in the hot loop. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing optimize-regexp-replace-v2 (ab44f24) to c17c87c (merge-base) diff using: tpch File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
…_read Replace HIR-based regex splitting with a simple string check: strip trailing `.*$` from anchored patterns and use captures_read with pre-allocated CaptureLocations for direct extraction. Eliminates regex-syntax dependency, expand(), and String allocation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
run benchmarks |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing optimize-regexp-replace-v2 (2bce86b) to c17c87c (merge-base) diff using: clickbench_partitioned File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing optimize-regexp-replace-v2 (2bce86b) to c17c87c (merge-base) diff using: tpcds File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing optimize-regexp-replace-v2 (2bce86b) to c17c87c (merge-base) diff using: tpch File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Dandandan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Performance optimization, no issue.
Rationale for this change
regexp_replacewith anchored patterns like^https?://(?:www\.)?([^/]+)/.*$spends time scanning the trailing.*$and usingcaptures()+expand()withStringallocation on every row.It just happens this
SELECT regexp_replace(url, '^https?://(?:www\.)?([^/]+)/.*$', '\1')query benefits from this optimization (2.4x faster)What changes are included in this PR?
.*$from the pattern string for anchored patterns where the replacement is\1captures_readwith pre-allocatedCaptureLocationsfor direct byte-slice extractionAre these changes tested?
Yes, covered by existing
regexp_replaceunit tests, ClickBench sqllogictests, and the new URL domain extraction sqllogictest.Are there any user-facing changes?
No.