feat: Improve InListExpr types, flatten dict haystacks and validate in try_new_from_array#21402
Open
buraksenn wants to merge 1 commit intoapache:mainfrom
Open
feat: Improve InListExpr types, flatten dict haystacks and validate in try_new_from_array#21402buraksenn wants to merge 1 commit intoapache:mainfrom
buraksenn wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
physical-expr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
InListExprtypes and expectations #20969.Rationale for this change
To make needle/haystack more clear, add comments and with flattened we can use optimizations.
What changes are included in this PR?
try_new_from_arrayAre these changes tested?
Yes. I've added new tests and existing pass test.
Are there any user-facing changes?
Yes.
try_new_from_arraynow expects data types to be logically equal