Skip to content

Skip type erasure in trace_future/trace_block when no tracer is set#21414

Closed
Dandandan wants to merge 1 commit intoapache:mainfrom
Dandandan:optimize-trace-future
Closed

Skip type erasure in trace_future/trace_block when no tracer is set#21414
Dandandan wants to merge 1 commit intoapache:mainfrom
Dandandan:optimize-trace-future

Conversation

@Dandandan
Copy link
Copy Markdown
Contributor

Summary

  • Add fast path to trace_future and trace_block that skips the Box<dyn Any + Send> type erasure and downcast pipeline when no custom JoinSetTracer is registered (the common case)
  • When GLOBAL_TRACER is not set, returns the future/closure directly with minimal boxing overhead

Background

Profiling ClickBench queries showed trace_future's type erasure overhead accounted for ~12% of total CPU time. Even with the NoopTracer, every spawned task was paying the cost of:

  1. Boxing the result as Box<dyn Any + Send> (type erasure)
  2. Passing through the tracer (noop)
  3. Downcasting back from Box<dyn Any + Send> to T
  4. Double-boxing the future with .boxed()

Benchmark results (ClickBench, single iteration)

Notable improvements:

Query Before (ms) After (ms) Change
Q3 74.9 48.0 -36.0%
Q18 2517.5 2032.8 -19.3%
Q19 54.9 43.2 -21.3%
Q32 4497.6 4225.1 -6.1%
Q33 2671.2 2497.9 -6.5%
Total 43272.9 42092.2 -2.7%

Test plan

  • cargo test -p datafusion-common-runtime passes
  • cargo clippy -p datafusion-common-runtime --all-targets --all-features -- -D warnings clean
  • CI passes

🤖 Generated with Claude Code

When no custom JoinSetTracer is registered (the common case), the
trace_future and trace_block functions were still performing unnecessary
type erasure (boxing as Box<dyn Any + Send>) and downcast operations on
every spawned task.

Profiling ClickBench queries showed trace_future's type erasure overhead
accounted for ~12% of total CPU time across all queries.

This adds a fast path that checks GLOBAL_TRACER.get().is_none() and
returns the future/closure directly without the erase/trace/downcast
pipeline when no custom tracer is configured.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions bot added the common Related to common crate label Apr 6, 2026
@Dandandan
Copy link
Copy Markdown
Contributor Author

run benchmarks

@adriangbot
Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c4194227629-905-6684w 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing optimize-trace-future (45b0cd9) to c17c87c (merge-base) diff using: tpcds
Results will be posted here when complete


File an issue against this benchmark runner

@adriangbot
Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c4194227629-906-h9bxx 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing optimize-trace-future (45b0cd9) to c17c87c (merge-base) diff using: tpch
Results will be posted here when complete


File an issue against this benchmark runner

@adriangbot
Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c4194227629-904-7vfqh 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing optimize-trace-future (45b0cd9) to c17c87c (merge-base) diff using: clickbench_partitioned
Results will be posted here when complete


File an issue against this benchmark runner

@adriangbot
Copy link
Copy Markdown

🤖 Benchmark completed (GKE) | trigger

Instance: c4a-highmem-16 (12 vCPU / 65 GiB)

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected
Details

Comparing HEAD and optimize-trace-future
--------------------
Benchmark tpcds_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query     ┃                                     HEAD ┃                   optimize-trace-future ┃       Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1  │              6.82 / 7.38 ±0.79 / 8.93 ms │             6.64 / 7.09 ±0.80 / 8.69 ms │    no change │
│ QQuery 2  │        145.99 / 147.10 ±0.59 / 147.55 ms │       145.91 / 147.50 ±1.12 / 149.12 ms │    no change │
│ QQuery 3  │        113.16 / 113.74 ±0.55 / 114.77 ms │       113.19 / 113.61 ±0.26 / 113.93 ms │    no change │
│ QQuery 4  │    1284.27 / 1324.51 ±29.90 / 1372.16 ms │    1330.68 / 1341.88 ±8.26 / 1352.63 ms │    no change │
│ QQuery 5  │        170.74 / 172.55 ±1.28 / 174.43 ms │       173.12 / 174.75 ±2.33 / 179.38 ms │    no change │
│ QQuery 6  │       813.05 / 854.24 ±28.75 / 878.43 ms │      837.69 / 866.54 ±20.70 / 890.86 ms │    no change │
│ QQuery 7  │        348.19 / 350.20 ±1.90 / 352.76 ms │       356.46 / 358.74 ±2.06 / 361.50 ms │    no change │
│ QQuery 8  │        114.37 / 116.39 ±1.08 / 117.49 ms │       118.11 / 119.63 ±1.21 / 121.01 ms │    no change │
│ QQuery 9  │         99.47 / 101.39 ±2.24 / 105.76 ms │       104.70 / 108.10 ±1.72 / 109.27 ms │ 1.07x slower │
│ QQuery 10 │        104.68 / 105.91 ±0.88 / 107.35 ms │       109.02 / 109.55 ±0.43 / 110.18 ms │    no change │
│ QQuery 11 │       885.97 / 909.72 ±18.92 / 929.03 ms │      938.70 / 959.40 ±18.53 / 990.19 ms │ 1.05x slower │
│ QQuery 12 │           45.02 / 45.68 ±0.44 / 46.12 ms │          44.54 / 46.65 ±1.41 / 48.59 ms │    no change │
│ QQuery 13 │        395.76 / 398.40 ±1.99 / 400.84 ms │       402.84 / 404.69 ±1.52 / 406.56 ms │    no change │
│ QQuery 14 │     1009.19 / 1017.58 ±7.48 / 1031.45 ms │    1008.70 / 1013.71 ±3.25 / 1018.26 ms │    no change │
│ QQuery 15 │           15.92 / 16.86 ±0.95 / 18.36 ms │          15.78 / 16.48 ±0.52 / 17.32 ms │    no change │
│ QQuery 16 │              7.18 / 7.50 ±0.22 / 7.83 ms │             7.09 / 7.89 ±0.91 / 9.68 ms │ 1.05x slower │
│ QQuery 17 │        236.02 / 239.80 ±2.50 / 243.08 ms │       239.67 / 242.83 ±1.89 / 245.41 ms │    no change │
│ QQuery 18 │        127.87 / 129.16 ±0.71 / 129.86 ms │       127.66 / 129.73 ±1.27 / 131.58 ms │    no change │
│ QQuery 19 │        153.28 / 155.19 ±1.59 / 157.46 ms │       155.32 / 157.01 ±0.89 / 157.91 ms │    no change │
│ QQuery 20 │           13.36 / 13.87 ±0.53 / 14.84 ms │          13.84 / 14.30 ±0.27 / 14.55 ms │    no change │
│ QQuery 21 │           19.18 / 19.70 ±0.35 / 20.10 ms │          20.18 / 20.47 ±0.46 / 21.38 ms │    no change │
│ QQuery 22 │        478.20 / 482.42 ±3.48 / 488.70 ms │       479.28 / 483.87 ±4.00 / 490.79 ms │    no change │
│ QQuery 23 │       867.10 / 887.51 ±15.54 / 915.22 ms │      882.99 / 903.06 ±10.41 / 912.49 ms │    no change │
│ QQuery 24 │        386.57 / 390.44 ±3.31 / 396.23 ms │       391.17 / 396.80 ±3.56 / 401.97 ms │    no change │
│ QQuery 25 │        348.26 / 350.54 ±1.79 / 352.54 ms │       350.80 / 353.32 ±2.87 / 357.91 ms │    no change │
│ QQuery 26 │           81.92 / 83.08 ±0.90 / 84.06 ms │          82.67 / 84.40 ±1.95 / 87.84 ms │    no change │
│ QQuery 27 │              6.73 / 7.10 ±0.31 / 7.57 ms │             7.02 / 7.69 ±0.63 / 8.68 ms │ 1.08x slower │
│ QQuery 28 │        147.95 / 148.93 ±1.06 / 150.58 ms │       150.35 / 151.74 ±0.91 / 152.83 ms │    no change │
│ QQuery 29 │        289.25 / 292.73 ±1.87 / 294.10 ms │       292.09 / 295.78 ±2.51 / 299.98 ms │    no change │
│ QQuery 30 │           42.03 / 44.10 ±1.52 / 46.24 ms │          42.86 / 45.06 ±1.29 / 46.87 ms │    no change │
│ QQuery 31 │        168.89 / 171.13 ±1.80 / 173.80 ms │       172.19 / 174.38 ±1.52 / 176.80 ms │    no change │
│ QQuery 32 │           56.93 / 57.72 ±0.65 / 58.80 ms │          57.58 / 58.22 ±0.85 / 59.90 ms │    no change │
│ QQuery 33 │        139.30 / 141.00 ±1.51 / 143.05 ms │       139.85 / 141.02 ±1.20 / 142.79 ms │    no change │
│ QQuery 34 │              7.00 / 7.33 ±0.26 / 7.69 ms │             7.06 / 7.27 ±0.19 / 7.62 ms │    no change │
│ QQuery 35 │        106.96 / 109.30 ±1.46 / 110.84 ms │       107.20 / 109.89 ±1.68 / 111.91 ms │    no change │
│ QQuery 36 │              6.45 / 6.60 ±0.19 / 6.97 ms │             6.49 / 6.70 ±0.17 / 6.91 ms │    no change │
│ QQuery 37 │              8.29 / 8.85 ±0.34 / 9.27 ms │            8.37 / 9.13 ±0.71 / 10.43 ms │    no change │
│ QQuery 38 │           83.32 / 87.81 ±3.90 / 94.88 ms │          85.56 / 88.54 ±3.42 / 95.06 ms │    no change │
│ QQuery 39 │        123.60 / 126.34 ±2.23 / 130.05 ms │       126.22 / 129.08 ±2.79 / 133.70 ms │    no change │
│ QQuery 40 │        108.24 / 116.43 ±8.30 / 132.40 ms │       115.94 / 121.78 ±7.20 / 135.19 ms │    no change │
│ QQuery 41 │           14.32 / 14.79 ±0.53 / 15.79 ms │          14.85 / 15.45 ±0.44 / 16.16 ms │    no change │
│ QQuery 42 │        106.18 / 108.55 ±1.65 / 110.36 ms │       108.82 / 110.34 ±1.13 / 112.23 ms │    no change │
│ QQuery 43 │              5.89 / 6.07 ±0.17 / 6.39 ms │             6.07 / 6.22 ±0.20 / 6.61 ms │    no change │
│ QQuery 44 │           11.44 / 11.85 ±0.38 / 12.56 ms │          11.76 / 12.01 ±0.20 / 12.21 ms │    no change │
│ QQuery 45 │           52.37 / 53.37 ±0.73 / 54.52 ms │          51.59 / 53.74 ±1.25 / 55.30 ms │    no change │
│ QQuery 46 │             8.29 / 9.10 ±1.15 / 11.35 ms │             8.72 / 8.87 ±0.13 / 9.05 ms │    no change │
│ QQuery 47 │        692.71 / 702.02 ±5.35 / 708.31 ms │       695.93 / 708.11 ±7.31 / 718.05 ms │    no change │
│ QQuery 48 │        282.24 / 288.41 ±4.69 / 294.21 ms │       284.80 / 290.97 ±4.73 / 297.91 ms │    no change │
│ QQuery 49 │        250.92 / 252.96 ±3.04 / 258.89 ms │       253.56 / 257.36 ±2.84 / 260.65 ms │    no change │
│ QQuery 50 │        229.82 / 235.20 ±5.50 / 244.38 ms │       233.88 / 241.20 ±5.67 / 250.29 ms │    no change │
│ QQuery 51 │        180.80 / 184.76 ±3.25 / 190.41 ms │       184.76 / 186.28 ±1.18 / 188.20 ms │    no change │
│ QQuery 52 │        106.41 / 107.77 ±1.07 / 109.14 ms │       108.03 / 109.28 ±1.00 / 110.88 ms │    no change │
│ QQuery 53 │        102.00 / 103.48 ±0.98 / 104.60 ms │       102.61 / 103.33 ±0.66 / 104.47 ms │    no change │
│ QQuery 54 │        146.10 / 148.02 ±1.27 / 149.28 ms │       144.98 / 147.22 ±1.90 / 149.52 ms │    no change │
│ QQuery 55 │        106.82 / 108.05 ±1.33 / 110.20 ms │       106.13 / 107.86 ±1.31 / 109.96 ms │    no change │
│ QQuery 56 │        140.37 / 141.65 ±0.91 / 142.98 ms │       139.45 / 141.10 ±1.40 / 143.59 ms │    no change │
│ QQuery 57 │        171.58 / 174.61 ±1.64 / 176.51 ms │       172.88 / 175.61 ±1.44 / 176.91 ms │    no change │
│ QQuery 58 │        289.21 / 296.41 ±4.38 / 300.91 ms │       294.60 / 297.83 ±2.44 / 301.77 ms │    no change │
│ QQuery 59 │        195.87 / 199.27 ±3.40 / 204.88 ms │       197.07 / 200.69 ±2.50 / 204.46 ms │    no change │
│ QQuery 60 │        141.75 / 144.22 ±1.36 / 145.63 ms │       142.08 / 143.70 ±1.10 / 145.31 ms │    no change │
│ QQuery 61 │           12.97 / 13.32 ±0.29 / 13.81 ms │          13.17 / 13.48 ±0.18 / 13.70 ms │    no change │
│ QQuery 62 │      908.50 / 975.06 ±56.58 / 1071.14 ms │      898.63 / 945.23 ±32.07 / 991.08 ms │    no change │
│ QQuery 63 │        106.76 / 107.74 ±1.05 / 109.78 ms │       102.94 / 105.72 ±3.53 / 112.46 ms │    no change │
│ QQuery 64 │       691.54 / 701.83 ±15.53 / 732.44 ms │       696.52 / 708.96 ±8.73 / 718.29 ms │    no change │
│ QQuery 65 │        249.48 / 251.40 ±1.53 / 253.77 ms │       248.82 / 254.54 ±4.07 / 261.28 ms │    no change │
│ QQuery 66 │       226.91 / 241.57 ±12.65 / 262.38 ms │       245.05 / 256.90 ±6.92 / 264.59 ms │ 1.06x slower │
│ QQuery 67 │        313.30 / 317.73 ±4.15 / 325.47 ms │       306.35 / 317.08 ±6.58 / 323.94 ms │    no change │
│ QQuery 68 │             8.67 / 9.96 ±1.10 / 11.54 ms │            8.68 / 9.99 ±0.87 / 11.32 ms │    no change │
│ QQuery 69 │        101.14 / 103.90 ±2.24 / 106.85 ms │       102.78 / 104.98 ±1.87 / 108.03 ms │    no change │
│ QQuery 70 │       332.19 / 348.70 ±12.49 / 367.24 ms │      322.97 / 337.15 ±14.75 / 365.20 ms │    no change │
│ QQuery 71 │        134.03 / 136.95 ±2.92 / 142.37 ms │       135.88 / 137.45 ±1.91 / 141.10 ms │    no change │
│ QQuery 72 │       708.79 / 720.24 ±19.47 / 759.09 ms │       704.19 / 711.17 ±4.68 / 717.77 ms │    no change │
│ QQuery 73 │              6.41 / 7.25 ±0.71 / 8.42 ms │             6.68 / 7.60 ±0.64 / 8.48 ms │    no change │
│ QQuery 74 │        548.38 / 562.02 ±8.87 / 573.04 ms │      558.23 / 577.96 ±22.76 / 620.42 ms │    no change │
│ QQuery 75 │        272.91 / 276.72 ±2.58 / 279.89 ms │       276.89 / 279.67 ±2.54 / 283.65 ms │    no change │
│ QQuery 76 │        129.53 / 131.38 ±1.51 / 133.56 ms │       131.82 / 133.00 ±0.96 / 134.45 ms │    no change │
│ QQuery 77 │        187.68 / 189.05 ±1.95 / 192.90 ms │       187.39 / 189.28 ±1.71 / 192.42 ms │    no change │
│ QQuery 78 │        343.64 / 346.09 ±3.08 / 352.06 ms │       350.19 / 354.20 ±3.07 / 358.45 ms │    no change │
│ QQuery 79 │        230.98 / 236.27 ±3.74 / 241.15 ms │       227.95 / 229.87 ±1.02 / 230.74 ms │    no change │
│ QQuery 80 │        326.68 / 329.74 ±2.32 / 332.41 ms │       326.74 / 330.01 ±2.73 / 333.75 ms │    no change │
│ QQuery 81 │           26.39 / 27.16 ±0.64 / 28.04 ms │          26.07 / 27.32 ±1.04 / 29.06 ms │    no change │
│ QQuery 82 │        197.58 / 200.53 ±2.70 / 205.10 ms │       195.32 / 198.54 ±1.95 / 201.02 ms │    no change │
│ QQuery 83 │           38.08 / 40.00 ±1.89 / 43.55 ms │          39.54 / 40.48 ±0.78 / 41.77 ms │    no change │
│ QQuery 84 │           47.60 / 48.67 ±0.86 / 50.22 ms │          47.71 / 49.19 ±1.04 / 50.84 ms │    no change │
│ QQuery 85 │        145.62 / 148.20 ±1.45 / 149.88 ms │       147.99 / 150.17 ±1.60 / 152.15 ms │    no change │
│ QQuery 86 │           39.76 / 40.96 ±1.26 / 42.55 ms │          39.42 / 39.99 ±0.42 / 40.51 ms │    no change │
│ QQuery 87 │           84.80 / 89.66 ±3.47 / 94.83 ms │          85.06 / 88.09 ±3.72 / 95.23 ms │    no change │
│ QQuery 88 │        100.57 / 101.00 ±0.26 / 101.23 ms │         98.83 / 99.77 ±0.67 / 100.63 ms │    no change │
│ QQuery 89 │        117.71 / 118.79 ±0.78 / 119.70 ms │       117.09 / 119.76 ±1.74 / 122.58 ms │    no change │
│ QQuery 90 │           23.97 / 25.09 ±0.93 / 26.61 ms │          23.59 / 24.63 ±0.93 / 26.10 ms │    no change │
│ QQuery 91 │           62.09 / 65.55 ±1.91 / 67.68 ms │          63.48 / 64.35 ±0.73 / 65.34 ms │    no change │
│ QQuery 92 │           58.43 / 59.40 ±0.72 / 60.37 ms │          56.01 / 57.49 ±0.93 / 58.80 ms │    no change │
│ QQuery 93 │        189.43 / 193.47 ±2.77 / 196.46 ms │       191.41 / 193.12 ±1.55 / 195.76 ms │    no change │
│ QQuery 94 │           61.53 / 61.85 ±0.21 / 62.15 ms │          62.06 / 62.27 ±0.17 / 62.56 ms │    no change │
│ QQuery 95 │        134.89 / 135.79 ±0.54 / 136.43 ms │       134.18 / 136.03 ±1.21 / 137.94 ms │    no change │
│ QQuery 96 │           71.51 / 73.60 ±1.66 / 75.92 ms │          72.71 / 74.70 ±1.18 / 76.10 ms │    no change │
│ QQuery 97 │        131.51 / 132.90 ±1.03 / 134.27 ms │       129.37 / 131.36 ±1.94 / 134.12 ms │    no change │
│ QQuery 98 │        153.91 / 156.40 ±2.11 / 159.36 ms │       150.62 / 153.77 ±1.72 / 155.78 ms │    no change │
│ QQuery 99 │ 10788.66 / 10874.80 ±50.11 / 10923.28 ms │ 10760.84 / 10772.27 ±6.84 / 10779.53 ms │    no change │
└───────────┴──────────────────────────────────────────┴─────────────────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 31657.52ms │
│ Total Time (optimize-trace-future)   │ 31733.02ms │
│ Average Time (HEAD)                  │   319.77ms │
│ Average Time (optimize-trace-future) │   320.54ms │
│ Queries Faster                       │          0 │
│ Queries Slower                       │          5 │
│ Queries with No Change               │         94 │
│ Queries with Failure                 │          0 │
└──────────────────────────────────────┴────────────┘

Resource Usage

tpcds — base (merge-base)

Metric Value
Wall time 158.6s
Peak memory 5.5 GiB
Avg memory 4.5 GiB
CPU user 258.7s
CPU sys 17.0s
Peak spill 0 B

tpcds — branch

Metric Value
Wall time 159.0s
Peak memory 5.7 GiB
Avg memory 4.7 GiB
CPU user 260.2s
CPU sys 16.8s
Peak spill 0 B

File an issue against this benchmark runner

@adriangbot
Copy link
Copy Markdown

🤖 Benchmark completed (GKE) | trigger

Instance: c4a-highmem-16 (12 vCPU / 65 GiB)

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected
Details

Comparing HEAD and optimize-trace-future
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query     ┃                                  HEAD ┃                  optimize-trace-future ┃       Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 0  │          1.19 / 4.41 ±6.36 / 17.12 ms │           1.18 / 4.38 ±6.32 / 17.02 ms │    no change │
│ QQuery 1  │        14.38 / 14.53 ±0.17 / 14.85 ms │         14.16 / 14.67 ±0.30 / 15.07 ms │    no change │
│ QQuery 2  │        43.30 / 43.80 ±0.39 / 44.34 ms │         43.80 / 44.01 ±0.21 / 44.39 ms │    no change │
│ QQuery 3  │        42.44 / 43.69 ±1.04 / 44.88 ms │         43.00 / 44.94 ±1.20 / 46.28 ms │    no change │
│ QQuery 4  │     290.22 / 296.29 ±7.08 / 310.10 ms │      290.32 / 300.54 ±8.51 / 312.13 ms │    no change │
│ QQuery 5  │     340.91 / 346.39 ±4.24 / 353.66 ms │      345.98 / 351.05 ±3.90 / 356.62 ms │    no change │
│ QQuery 6  │           4.58 / 5.89 ±0.99 / 7.58 ms │           5.71 / 8.28 ±2.18 / 12.04 ms │ 1.41x slower │
│ QQuery 7  │        16.73 / 17.15 ±0.42 / 17.90 ms │         17.38 / 20.69 ±5.73 / 32.13 ms │ 1.21x slower │
│ QQuery 8  │     412.29 / 425.96 ±8.83 / 439.64 ms │      423.59 / 434.44 ±7.44 / 444.66 ms │    no change │
│ QQuery 9  │     626.42 / 629.40 ±1.95 / 631.43 ms │     637.43 / 655.78 ±12.63 / 673.85 ms │    no change │
│ QQuery 10 │        90.01 / 92.06 ±1.59 / 94.42 ms │        92.66 / 95.79 ±3.90 / 103.10 ms │    no change │
│ QQuery 11 │     102.33 / 103.94 ±1.48 / 106.61 ms │      105.14 / 105.89 ±0.55 / 106.57 ms │    no change │
│ QQuery 12 │     341.43 / 344.49 ±3.18 / 350.53 ms │     344.53 / 357.54 ±11.29 / 374.82 ms │    no change │
│ QQuery 13 │    450.71 / 463.84 ±12.30 / 486.91 ms │     456.35 / 476.58 ±21.53 / 517.40 ms │    no change │
│ QQuery 14 │     347.11 / 349.52 ±1.64 / 352.21 ms │      356.41 / 364.59 ±5.01 / 371.21 ms │    no change │
│ QQuery 15 │    354.33 / 369.33 ±16.39 / 401.21 ms │     366.18 / 381.38 ±14.89 / 406.40 ms │    no change │
│ QQuery 16 │    721.97 / 738.06 ±16.33 / 766.94 ms │     743.83 / 759.04 ±16.69 / 787.36 ms │    no change │
│ QQuery 17 │     712.93 / 721.24 ±5.52 / 728.35 ms │     740.97 / 772.61 ±53.90 / 880.09 ms │ 1.07x slower │
│ QQuery 18 │ 1430.08 / 1475.03 ±35.27 / 1512.25 ms │ 1503.88 / 1618.77 ±157.99 / 1927.18 ms │ 1.10x slower │
│ QQuery 19 │        34.25 / 36.80 ±2.32 / 40.89 ms │         39.20 / 42.19 ±4.51 / 51.15 ms │ 1.15x slower │
│ QQuery 20 │    713.08 / 731.43 ±22.01 / 764.58 ms │     723.27 / 747.88 ±30.20 / 804.33 ms │    no change │
│ QQuery 21 │     757.25 / 764.96 ±4.95 / 771.01 ms │      771.44 / 774.42 ±3.47 / 781.16 ms │    no change │
│ QQuery 22 │  1130.70 / 1138.11 ±7.33 / 1150.44 ms │   1140.85 / 1145.92 ±5.05 / 1155.48 ms │    no change │
│ QQuery 23 │ 3065.94 / 3087.29 ±16.89 / 3108.58 ms │  3071.51 / 3083.68 ±13.23 / 3106.79 ms │    no change │
│ QQuery 24 │      98.33 / 103.91 ±3.38 / 108.23 ms │      100.51 / 103.71 ±3.88 / 110.87 ms │    no change │
│ QQuery 25 │     139.16 / 140.37 ±0.99 / 142.18 ms │      138.89 / 140.47 ±1.41 / 142.89 ms │    no change │
│ QQuery 26 │     100.69 / 102.44 ±1.42 / 104.25 ms │       98.38 / 102.23 ±3.40 / 107.25 ms │    no change │
│ QQuery 27 │     848.62 / 852.07 ±3.56 / 858.82 ms │      844.71 / 854.37 ±6.78 / 865.78 ms │    no change │
│ QQuery 28 │ 7707.12 / 7782.07 ±39.89 / 7824.04 ms │  7916.06 / 7975.29 ±41.94 / 8043.49 ms │    no change │
│ QQuery 29 │        50.12 / 54.43 ±5.13 / 63.02 ms │         51.59 / 55.78 ±3.59 / 62.07 ms │    no change │
│ QQuery 30 │     361.87 / 370.13 ±6.56 / 377.84 ms │      378.99 / 385.15 ±5.07 / 393.81 ms │    no change │
│ QQuery 31 │     373.67 / 378.97 ±3.50 / 382.40 ms │     374.23 / 393.43 ±19.64 / 428.61 ms │    no change │
│ QQuery 32 │ 1037.30 / 1066.92 ±34.56 / 1134.65 ms │  1063.77 / 1116.32 ±50.65 / 1183.16 ms │    no change │
│ QQuery 33 │  1470.85 / 1476.54 ±4.73 / 1483.20 ms │  1503.52 / 1530.00 ±15.93 / 1552.58 ms │    no change │
│ QQuery 34 │ 1456.84 / 1472.41 ±14.41 / 1499.05 ms │  1487.02 / 1506.75 ±13.20 / 1524.00 ms │    no change │
│ QQuery 35 │     381.17 / 389.60 ±4.46 / 393.98 ms │      387.52 / 398.73 ±6.44 / 406.91 ms │    no change │
│ QQuery 36 │     120.41 / 122.20 ±1.63 / 125.10 ms │      122.76 / 124.91 ±1.88 / 128.40 ms │    no change │
│ QQuery 37 │        49.75 / 51.01 ±0.92 / 52.10 ms │         48.92 / 50.71 ±1.60 / 53.28 ms │    no change │
│ QQuery 38 │        75.18 / 76.08 ±0.77 / 77.06 ms │         74.64 / 76.17 ±1.04 / 77.40 ms │    no change │
│ QQuery 39 │     201.73 / 215.44 ±7.20 / 222.19 ms │      205.55 / 217.17 ±7.40 / 226.80 ms │    no change │
│ QQuery 40 │        21.84 / 25.02 ±2.64 / 28.88 ms │         23.72 / 25.36 ±0.95 / 26.37 ms │    no change │
│ QQuery 41 │        19.58 / 20.76 ±1.00 / 22.52 ms │         19.97 / 21.24 ±0.83 / 22.03 ms │    no change │
│ QQuery 42 │        18.91 / 19.26 ±0.19 / 19.44 ms │         19.87 / 20.24 ±0.35 / 20.87 ms │ 1.05x slower │
└───────────┴───────────────────────────────────────┴────────────────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 26963.23ms │
│ Total Time (optimize-trace-future)   │ 27703.08ms │
│ Average Time (HEAD)                  │   627.05ms │
│ Average Time (optimize-trace-future) │   644.26ms │
│ Queries Faster                       │          0 │
│ Queries Slower                       │          6 │
│ Queries with No Change               │         37 │
│ Queries with Failure                 │          0 │
└──────────────────────────────────────┴────────────┘

Resource Usage

clickbench_partitioned — base (merge-base)

Metric Value
Wall time 135.9s
Peak memory 43.1 GiB
Avg memory 30.1 GiB
CPU user 1286.6s
CPU sys 84.4s
Peak spill 0 B

clickbench_partitioned — branch

Metric Value
Wall time 139.7s
Peak memory 43.4 GiB
Avg memory 31.4 GiB
CPU user 1319.1s
CPU sys 89.7s
Peak spill 0 B

File an issue against this benchmark runner

@Dandandan Dandandan closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants