bench: add ASOF join benchmarks - #23833
Draft
Xuanwo wants to merge 59 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23833 +/- ##
==========================================
+ Coverage 81.03% 81.19% +0.16%
==========================================
Files 1107 1114 +7
Lines 385064 392337 +7273
Branches 385064 392337 +7273
==========================================
+ Hits 312040 318568 +6528
- Misses 54616 55025 +409
- Partials 18408 18744 +336 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
# Conflicts: # datafusion/expr/src/logical_plan/plan.rs
Co-authored-by: Yongting You <2010youy01@gmail.com>
# Conflicts: # datafusion/expr/src/logical_plan/tree_node.rs # datafusion/optimizer/src/analyzer/type_coercion.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This is the benchmark layer of the ASOF JOIN stack. It keeps performance
workloads separate from the execution, logical, and SQL implementation reviews.
GitHub shows the cumulative stack because fork branches cannot be selected as
upstream PR bases. The isolated diff for this layer is:
Xuanwo/datafusion@xuanwo/asof-sql...xuanwo/asof-benchmarks
What changes are included in this PR?
dfbench asofcommand with six end-to-end workloads: ordered andgrouped predecessor matching, wide payloads, descending successor matching,
broadcast-side size asymmetry, and skewed equality keys.
AsOfJoinExec.payloads.
single-partitioned, covering broadcast build reuse and left-side parallelism.
Are these changes tested?
Yes:
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo run -p datafusion-benchmarks --bin dfbench -- asof --iterations 1 --partitions 4cargo bench -p datafusion-physical-plan --bench asof_join --features test_utils -- --testThe refreshed head completed all six end-to-end workloads with the expected
1,000,000, 1,000,000, 250,000, 500,000, 100,000, and 1,000,000 row counts. The
Criterion smoke run completed all six combinations of payload type and left
partition count. These debug/smoke runs validate the
harness and are not presented as performance claims.
Are there any user-facing changes?
This adds ASOF workloads to the repository benchmark tooling. It does not change
query semantics or runtime behavior.
This PR should be reviewed and merged after #23830. After its dependencies
squash-merge, this branch will be refreshed from
mainwithout rewriting itspublished history.