bench: Add benchmarks for ordered ARRAY_AGG and STRING_AGG - #24391
bench: Add benchmarks for ordered ARRAY_AGG and STRING_AGG#24391lyne7-sc wants to merge 1 commit into
ARRAY_AGG and STRING_AGG#24391Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24391 +/- ##
==========================================
- Coverage 81.19% 81.19% -0.01%
==========================================
Files 1110 1110
Lines 388616 388750 +134
Branches 388616 388750 +134
==========================================
+ Hits 315529 315627 +98
- Misses 54506 54535 +29
- Partials 18581 18588 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alamb
left a comment
There was a problem hiding this comment.
Thanks @lyne7-sc this is a neat idea to introduce a new benchmark suite. I wonder if there are any existing suites that might be better places to add this rather than a whole new suite. Or if we are going to make a new suite, shall we consolidate other benchmarks here for aggregates 🤔
FYI @Omega359 -- here is a use of the new sql benchmark suite
|
Thanks @alamb - it's good to know that it's being used :) I do have two PR's in progress to sync up the benchmarks with the latest changes and to impl the bench.sh linkage. I just need to find the time which is in short supply given the amazing weather right now :) |
Nice -- will look forward to them (and I totally understand re weather -- it is pretty nice here too!) |
|
Thanks @alamb and @Omega359. The new SQL benchmark framework is very nice to use. Most aggregate benchmarks I found focus on individual accumulator operations such as If this direction makes sense, I think we could migrate the other end-to-end aggregate cases into this suite. Alternatively, if there is another existing suite or location that would be a better fit, I’m happy to move these cases there. |
Which issue does this PR close?
Rationale for this change
Add benchmarks for ordered aggregate functions, including the ordered
ARRAY_AGGworkloadWhat changes are included in this PR?
This PR adds a reusable SQL benchmark suite for aggregate functions.
The initial cases cover:
ARRAY_AGGwith multiple ordering expressions.ARRAY_AGGexpressions with different ordering requirements.STRING_AGGwith multiple ordering expressions.Are these changes tested?
Yes.
Are there any user-facing changes?
No. This PR only adds benchmarks.