fix: remap SortMergeJoin filter during projection pushdown - #24415
Open
haohuaijin wants to merge 4 commits into
Open
fix: remap SortMergeJoin filter during projection pushdown#24415haohuaijin wants to merge 4 commits into
haohuaijin wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24415 +/- ##
==========================================
+ Coverage 81.23% 81.24% +0.01%
==========================================
Files 1111 1111
Lines 390208 390221 +13
Branches 390208 390221 +13
==========================================
+ Hits 316990 317045 +55
+ Misses 54591 54549 -42
Partials 18627 18627 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
SortMergeJoinprojection pushdown can reuse stale JoinFilter indices #24414.Rationale for this change
Projection pushdown through
SortMergeJoinExeccould reuse stale join-filter indices and return incorrect results.What changes are included in this PR?
JoinFilterduring projection pushdown.Are these changes tested?
Yes. The SQLLogicTest verifies the physical plan and the expected
(1, 1)result. The full Rust lint and extended workspace test suites also pass.Are there any user-facing changes?
Affected queries now return correct results. There are no API changes.