Apply same sparse routing for range partition dynamic filter as hash partition and restructure build_filter - #24417
Open
peterxcli wants to merge 3 commits into
Conversation
Member
Author
|
cc @alamb as you suggest this refactor, @adriangb as you're the author of #18393, #18451 and #21666 Please take a look if you have time. TIA |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24417 +/- ##
==========================================
- Coverage 81.23% 81.23% -0.01%
==========================================
Files 1111 1111
Lines 390208 390194 -14
Branches 390208 390194 -14
==========================================
- Hits 316990 316968 -22
- Misses 54591 54598 +7
- Partials 18627 18628 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
per #23854 (comment)
Rationale for this change
SharedBuildAccumulator.build_filteris too complicated and too clever to understand, need to extract it into smaller pieces of logic block.What changes are included in this PR?
keygo.build_filterinshared_boundstobuild_collect_left_filterandbuild_partitioned_filter, and add comment explanation throughout the code. The most complicated part are filter building fast-path(all_partitions_canceled,all_partitions_emptyandone_non_empty_partition) and sparse branches filter building. btw, I skipped documenting the state management forPartitionStatusbecause I think its code is already self-explanatory.Are these changes tested?
Are there any user-facing changes?
no