[enhance](cloud) proactively sync tablet meta after alter#61585
Open
luwei16 wants to merge 7 commits intoapache:masterfrom
Open
[enhance](cloud) proactively sync tablet meta after alter#61585luwei16 wants to merge 7 commits intoapache:masterfrom
luwei16 wants to merge 7 commits intoapache:masterfrom
Conversation
FE now sends a sync_tablet_meta RPC to all alive cloud backends after alter updates tablet meta in meta service. The request carries affected tablet ids and is dispatched as a best-effort notification, so alter success still depends on meta service update instead of backend acknowledgements. BE handles the RPC by refreshing meta only for tablets that are already cached locally. Uncached tablets are skipped, which avoids polluting tablet cache while still fixing stale compaction policy and related tablet meta on active compute clusters. The RPC also returns synced/skipped/failed counts and exposes bvar counters for observability. This change adds FE and BE unit tests and a cloud regression suite. The regression covers cached and uncached multi-cluster behavior, the negative path with proactive notify disabled, and the version-limit scenario where a size_based table hits too many versions, is altered to time_series, and can accept new writes immediately after alter.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 26984 ms |
TPC-DS: Total hot run time: 167520 ms |
### What problem does this PR solve? Issue Number: None Related PR: apache#61585 Problem Summary: Newly added cloud tablet sync_meta tests expect tablet_schema.is_in_memory to be refreshed together with other tablet meta fields, but sync_meta only updated compaction and ttl related properties. ### Release note None ### Check List (For Author) - Test: Partial verification only - BE unit test build started with ./run-be-ut.sh --run --filter=CloudInternalServiceTest.*:CloudTabletMgrTest.TestGetTabletIfCachedOnlyReturnsCachedTablet:CloudTabletSyncMetaTest.* -j8, but full result was not available in this session because first-time worktree dependency compilation (openblas/faiss) was still running - Behavior changed: Yes (cloud tablet meta refresh now also syncs tablet_schema.is_in_memory) - Does this need documentation: No
### What problem does this PR solve? Issue Number: None Related PR: apache#61585 Problem Summary: The previous follow-up fix made CloudTablet::sync_meta refresh tablet_schema.is_in_memory, but this property should not be synchronized in cloud tablet meta refresh. Adjust the BE UT to validate the intended behavior while keeping ttl synchronization covered. ### Release note None ### Check List (For Author) - Test: Partial verification only - Updated the affected BE unit test expectation; full ./run-be-ut.sh verification was still compiling first-time worktree dependencies in this session - Behavior changed: Yes (sync_meta no longer updates tablet_schema.is_in_memory; UT now asserts that behavior) - Does this need documentation: No
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 26803 ms |
TPC-DS: Total hot run time: 169435 ms |
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 26750 ms |
TPC-DS: Total hot run time: 169803 ms |
Contributor
Author
|
run beut |
1 similar comment
Contributor
Author
|
run beut |
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 29678 ms |
TPC-DS: Total hot run time: 180426 ms |
Contributor
Author
|
run p0 |
Contributor
Author
|
run beut |
Contributor
Author
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
PR approved by anyone and no changes requested. |
gavinchou
reviewed
Apr 17, 2026
| int64_t synced = 0; | ||
| int64_t skipped = 0; | ||
| int64_t failed = 0; | ||
| g_cloud_sync_tablet_meta_requests_total << 1; |
Contributor
There was a problem hiding this comment.
LOG the request and response
tablet list and time taken
gavinchou
reviewed
Apr 17, 2026
| return; | ||
| } | ||
|
|
||
| InternalService.PSyncTabletMetaRequest request = InternalService.PSyncTabletMetaRequest.newBuilder() |
Contributor
There was a problem hiding this comment.
log the request
table and tablet list
and time taken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FE now sends a sync_tablet_meta RPC to all alive cloud backends after alter updates tablet meta in meta service. The request carries affected tablet ids and is dispatched as a best-effort notification, so alter success still depends on meta service update instead of backend acknowledgements.
BE handles the RPC by refreshing meta only for tablets that are already cached locally. Uncached tablets are skipped, which avoids polluting tablet cache while still fixing stale compaction policy and related tablet meta on active compute clusters. The RPC also returns synced/skipped/failed counts and exposes bvar counters for observability.
This change adds FE and BE unit tests and a cloud regression suite. The regression covers cached and uncached multi-cluster behavior, the negative path with proactive notify disabled, and the version-limit scenario where a size_based table hits too many versions, is altered to time_series, and can accept new writes immediately after alter.