[upgrade](thirdparty) Add aws cpp sdk kinesis #62184
Open
0AyanamiRei wants to merge 17 commits intoapache:masterfrom
Open
[upgrade](thirdparty) Add aws cpp sdk kinesis #621840AyanamiRei wants to merge 17 commits intoapache:masterfrom
0AyanamiRei wants to merge 17 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
16 tasks
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
run buildall |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Found 1 issue.
- [high]
be/cmake/thirdparty.cmakenow unconditionally importsaws-cpp-sdk-kinesis, but the stale-thirdparty rebuild path is still incomplete.build.shonly checks for${DORIS_THIRDPARTY}/installed/lib/hadoop_hdfs/native/libhdfs.abefore deciding whether to rerunthirdparty/build-thirdparty.sh(build.sh:354-369). On any machine or CI cache that already has thirdparty built from before this change,./build.sh --beskips rebuilding thirdparty, soinstalled/lib64/libaws-cpp-sdk-kinesis.ais still missing and the BE configure/link step fails as soon as this imported target is consumed. This PR needs to update the rebuild detection together with the new imported library.
Critical checkpoints:
- Goal of the task: Partially accomplished. The PR adds kinesis to the AWS SDK build list and BE thirdparty imports, but it does not safely handle existing thirdparty installations, so the stated goal is not met end-to-end. No build/test evidence was included to prove the upgrade path works.
- Minimality/focus: Yes. The change set is small and focused on thirdparty wiring.
- Concurrency: Not applicable.
- Special lifecycle/static init: Not applicable.
- Configuration changes: None.
- Incompatible changes: No protocol/storage compatibility concerns, but there is a build-environment compatibility regression for existing thirdparty caches.
- Parallel code paths: The relevant parallel path is the existing thirdparty reuse/rebuild flow in
build.sh; it was not updated along with the new imported library. - Special conditional checks: The existing
LAST_THIRDPARTY_LIBcheck is now too narrow for this change. - Test coverage: No regression/unit/build validation was shown. For a build-system change, at least a clean/incremental build check is needed.
- Observability: Not applicable.
- Transaction/persistence/data-write/FE-BE variable passing: Not applicable.
- Performance: No notable issue in the patch itself.
- Other issues: None beyond the incremental-build regression above.
Contributor
|
run buildall |
Add function to check if thirdparty files have changed
Contributor
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
used for #61325
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)