[fix](mv) Align extra-join elimination safety check #62527
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| -- This file is automatically generated. You should know what you did if you want to edit this | ||
| -- !join_elim_filter_edge -- | ||
| 1 Alice | ||
| 2 Bob | ||
| 3 Charlie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| package mv.join_elim_p_f_key | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| suite("join_elim_filter_edge") { | ||
| String db = context.config.getDbNameByFile(context.file) | ||
| sql "use ${db}" | ||
| sql "SET enable_nereids_planner=true" | ||
| sql "SET enable_fallback_to_original_planner=false" | ||
| sql "SET enable_materialized_view_rewrite=true" | ||
| sql "SET enable_nereids_timeout = false" | ||
|
|
||
| sql """DROP MATERIALIZED VIEW IF EXISTS mv_join_elim_filter_edge""" | ||
| sql """DROP TABLE IF EXISTS join_elim_filter_edge_t1""" | ||
| sql """DROP TABLE IF EXISTS join_elim_filter_edge_t2""" | ||
|
|
||
| sql """CREATE TABLE join_elim_filter_edge_t1 ( | ||
| id INT, | ||
| name VARCHAR(50) | ||
| ) | ||
| DUPLICATE KEY(id) | ||
| DISTRIBUTED BY HASH(id) BUCKETS 1 | ||
| PROPERTIES ("replication_allocation" = "tag.location.default: 1");""" | ||
|
|
||
| sql """CREATE TABLE join_elim_filter_edge_t2 ( | ||
| id INT, | ||
| value INT | ||
| ) | ||
| UNIQUE KEY(id) | ||
| DISTRIBUTED BY HASH(id) BUCKETS 1 | ||
| PROPERTIES ( | ||
| "replication_allocation" = "tag.location.default: 1", | ||
| "enable_unique_key_merge_on_write" = "true" | ||
| );""" | ||
|
|
||
| sql """ALTER TABLE join_elim_filter_edge_t2 ADD CONSTRAINT uk_id UNIQUE (id)""" | ||
|
|
||
| sql """INSERT INTO join_elim_filter_edge_t1 VALUES | ||
| (1, 'Alice'), | ||
| (2, 'Bob'), | ||
| (3, 'Charlie');""" | ||
|
|
||
| sql """INSERT INTO join_elim_filter_edge_t2 VALUES | ||
| (1, 10), | ||
| (2, -5), | ||
| (4, 20);""" | ||
|
|
||
| sql """ANALYZE TABLE join_elim_filter_edge_t1 WITH SYNC;""" | ||
| sql """ANALYZE TABLE join_elim_filter_edge_t2 WITH SYNC;""" | ||
| sql """ALTER TABLE join_elim_filter_edge_t1 MODIFY COLUMN name SET STATS ('row_count'='3');""" | ||
| sql """ALTER TABLE join_elim_filter_edge_t2 MODIFY COLUMN value SET STATS ('row_count'='3');""" | ||
|
|
||
| create_async_mv(db, "mv_join_elim_filter_edge", """ | ||
| SELECT | ||
| t1.id, | ||
| t1.name | ||
| FROM join_elim_filter_edge_t1 t1 | ||
| LEFT JOIN join_elim_filter_edge_t2 t2 | ||
| ON t1.id = t2.id AND t2.id = 1 | ||
| """) | ||
|
|
||
| def querySql = """SELECT id, name FROM join_elim_filter_edge_t1""" | ||
| mv_rewrite_success_without_check_chosen(querySql, "mv_join_elim_filter_edge") | ||
| order_qt_join_elim_filter_edge """SELECT id, name FROM join_elim_filter_edge_t1 ORDER BY 1, 2""" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use e.getReferenceNodes()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FilterEdge.getReferenceNodes() is the whole filter child subtree, not the nodes actually referenced by the filter predicate. In HyperGraph.addFilter() we build the edge with subTreeNodes, so for a filter above t1 LEFT JOIN t2, getReferenceNodes() contains both sides even if the predicate only uses preserved-side columns, e.g. WHERE t1.id > 1. Using it here would therefore over-block safe elimination. getInputNodes() is narrower: it tracks the actual predicate lineage from input slots (including projected aliases), and only falls back to the whole subtree for slot-free predicates such as 1 = 0, where the filter really affects the entire child subtree. That is the dependency we want for this safety check.