branch-4.1: [fix](orc) handle cancellation during condition cache seek #67141 - #67321
Merged
Conversation
### What problem does this PR solve?
Issue Number: DORIS-28199
Problem Summary:
Condition-cache granule skipping can call ORC seekToRow before the
existing nextBatch exception boundary. When a query is cancelled during
that I/O, the ORC input stream throws a stop exception that escapes
get_block and may terminate the BE process.
### Release note
Fix BE process termination when an ORC scan is cancelled during
condition-cache seeking.
### Check List (For Author)
- Test
- [x] Regression test
- [x] Unit Test
- [ ] Manual test
- [ ] No need to test or manual test.
Verification: NewOrcReaderTest.* passed 163/163 under ASAN_UT.
Clang-format 16 passed for both affected C++ files.
- Behavior changed:
- [ ] No.
- [x] Yes. Cancellation during a condition-cache seek now returns clean
EOF instead of allowing the ORC stop exception to escape.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
skip buildall |
yiguolei
approved these changes
Aug 31, 2026
Contributor
Author
|
PR approved by anyone and no changes requested. |
github-actions
Bot
added
the
approved
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #67141