Repository navigation
feat(legend): support series name in formatter. close #21730 - #21815
Open
Mohitmhatre32 wants to merge 1 commit into
Open
Mohitmhatre32 wants to merge 1 commit into
Mohitmhatre32 wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is:
What does this PR do?
Adds support for passing the associated series name as the second argument to the
legend.formattercallback.Related Issue: #21730 — Support
legend.formatter(name, seriesName)Details
Before: What was the problem?
Previously, the
legend.formattercallback received only the legend item name:This made it difficult to identify the associated series, particularly when working with data-item legends such as pie charts.
After: How does it work now?
The callback now receives both the legend item name and its associated series name:
Usage Example:
The second argument is optional, ensuring backward compatibility with existing formatter callbacks.
namecontinue to work.Tests Added
Unit tests have been added to cover:
Test File:
test/ut/spec/component/legend/formatter.test.tsValidation & Testing
The following checks have been completed successfully:
Documentation
apache/echarts-doc#xxx.Miscellaneous
Security Checking
ZRender Changes
ecomfe/zrender#xxx).Merging Options
Commit Message
Summary: This enhancement extends the
legend.formattercallback with an optionalseriesNameargument, making it easier to associate legend items with their respective series while maintaining backward compatibility.