[FLINK-39503][runtime-web] Auto-fit Job Overview DAG height and add recenter control#27981
Open
spuru9 wants to merge 2 commits intoapache:masterfrom
Open
[FLINK-39503][runtime-web] Auto-fit Job Overview DAG height and add recenter control#27981spuru9 wants to merge 2 commits intoapache:masterfrom
spuru9 wants to merge 2 commits intoapache:masterfrom
Conversation
…ecenter control Makes the default graph container height adapt to the viewport (clamped to [280, 500] at 40% of innerHeight) and re-applies on window resize until the user manually drags the horizontal divider. Adds a recenter button (aim icon) in the graph's bottom-right and a Ctrl+Space keyboard shortcut that invokes the existing moveToCenter() API, so users can quickly restore the centered view after panning/zooming.
Contributor
Author
|
@och5351 Can you help check this. Some minor changes in job page as told. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The Job Overview page's DAG graph opens at a fixed default height (500px). A horizontal divider lets users drag it, but until they do, the default doesn't adapt to the viewport — it feels cramped on shorter screens and leaves usable space unused on taller ones. Users who pan or zoom the DAG also have no quick way to restore its centered view.
This pull request makes the default graph height auto-fit the viewport and adds a recenter affordance.
Brief change log
clamp(280, innerHeight * 0.4, 500)); preserved once the user drags the divider.Ctrl+Spaceshortcut invoke the existingmoveToCenter().Verifying this change
UI-only change, no unit tests. Verified manually: graph height adapts on load and window resize; manual drag is preserved; recenter button and shortcut both re-center the DAG after pan/zoom.
Before (Default opening in MacBook 13" 100%):
After:
Added for recentering and moving to the default zoom.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 4.7)