[FLINK-34335][table] Print query hints in RexSubQuery explain output#28681
Open
Au-Miner wants to merge 2 commits into
Open
[FLINK-34335][table] Print query hints in RexSubQuery explain output#28681Au-Miner wants to merge 2 commits into
Au-Miner wants to merge 2 commits into
Conversation
Collaborator
featzhang
reviewed
Jul 8, 2026
featzhang
left a comment
Member
There was a problem hiding this comment.
left a few inline comments, no blocking issues from my side
featzhang
reviewed
Jul 8, 2026
featzhang
left a comment
Member
There was a problem hiding this comment.
left a few inline comments, no blocking issues from my side
Contributor
Author
|
Hi @featzhang, thanks for the review. If you have any other questions, please feel free to contact me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix query hints inside RexSubQuery so they are visible in explain output, including sibling subqueries with different join hints.
Brief change log
RelTreeWriterImpl#itemto detect RexSubQuery expressions and render their inner rel plans with hint-aware output.RelTreeWriterImpl#addHintItems, so main explain and subquery explain use the same query hint and query block alias rules.Verifying this change
Added
JoinHintTestBase#testJoinHintWithDifferentHintsInSiblingSubQueriesand updated the join hint XML plans for broadcast, shuffle hash, nest loop, and shuffle merge hints to assert subquery hints are printed correctly.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation