[MINOR] Use GlutenCoreConfig API in GlobalOffHeapMemoryTarget#mode - #12764
Open
changfan2757 wants to merge 1 commit into
Open
[MINOR] Use GlutenCoreConfig API in GlobalOffHeapMemoryTarget#mode#12764changfan2757 wants to merge 1 commit into
changfan2757 wants to merge 1 commit into
Conversation
|
Run Gluten Clickhouse CI on x86 |
Author
|
Hi @zhouyuan, this PR updates the ClickHouse CI workflow / x86 CI configuration. |
zhouyuan
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
What changes were proposed in this pull request?
Simplify
GlobalOffHeapMemoryTarget#modeby usingGlutenCoreConfig.get.dynamicOffHeapSizingEnabledinstead of manually reading the config key via
SparkEnv.get.conf.getBoolean(...).Why are the changes needed?
GlutenCoreConfigalready provides a type-safe accessor for this config withthe default value defined in one place. Using the raw key duplicates the default
value and bypasses the existing abstraction.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests. No behavior change.