Migrate grails-data-neo4j to Groovy 4/Jakarta/GORM 8 baseline by borinquenkid · Pull Request #15816 · apache/grails-core

borinquenkid · 2026-07-03T03:09:25Z

Summary

Baseline migration (PR1 of the Neo4j GormRegistry migration plan): bumps grails-data-neo4j's dependency stack to match root-repo (Groovy 4.0.32, Jakarta EE 10, GORM 8.0.0-SNAPSHOT, Spring Boot 4.1), with no GormRegistry behavioral change. The module previously didn't compile against these versions at all; it now compiles and its test suite runs (181/215 passing, 34 explicitly @PendingFeature with documented reasons, 0 unaccounted failures).

Build/dependency fixes: force Jetty to 9.4.43 and neo4j-java-driver to 4.4.13 on the test classpath (Spring Boot 4.1's BOM silently upgrades both to binary-incompatible major versions); add --add-opens for java.lang/sun.nio.ch (embedded Neo4j 3.5.x reflects into JDK internals); replace dead javax.el/el-impl with jakarta.el/expressly; add geantyref/byte-buddy (needed by Spock's Mock() at runtime, not declared by spock-core).
Two real, previously-latent bugs fixed in Neo4j's own source: GraphClassMapping#getMappedForm() infinite recursion under Groovy 4's changed property-resolution precedence; Neo4jQuery#applyOrderAndLimits() null-unsafe offset/max checks that crashed most unpaginated queries (this alone was blocking the majority of the suite). Also fixed GormStaticApi#saveAll()'s shared bug (returns null instead of persisted ids) via a Neo4j-side override, and added GraphGormMappingFactory#createDefaultIdentityMapping() so named/custom id generators (e.g. "snowflake") don't throw.
TCK migration: introduces GrailsDataNeo4jTckManager + Neo4jGormDatastoreSpec, migrating all 37 spec files off the old adapter-specific GormDatastoreSpec onto the shared grails-datamapping-tck framework, matching Hibernate5/7 and MongoDB's pattern.

The remaining 34 pending tests are annotated with the exact reason each is blocked - the majority (~19) on Neo4jGormApiFactory not yet being registered with GormRegistry (PR2 scope), plus a handful of narrower, individually-documented gaps not yet root-caused.

Test plan

./gradlew publishToMavenLocal -PskipTests from repo root, then cd grails-data-neo4j && ./gradlew build - compiles clean
./gradlew :grails-datastore-gorm-neo4j:test - BUILD SUCCESSFUL, 215 tests / 0 failures / 181 passing / 34 @PendingFeature

🤖 Generated with Claude Code

Copilot

Pull request overview

Migrates the grails-data-neo4j sub-build onto the Grails 8 / GORM 8 / Groovy 4 / Jakarta EE 10 baseline so it compiles and (mostly) runs its test suite within the main grails-core repo, while also modernizing its TCK integration to match other datastore adapters.

Changes:

Update grails-data-neo4j build and dependency stack for Groovy 4 / Spring 7 / Spring Boot 4.1 / Jakarta, including test-runtime dependency alignment for embedded Neo4j harness compatibility.
Migrate Neo4j adapter tests onto grails-datamapping-tck via a new Neo4j-specific TCK manager + base spec, replacing the old adapter-local GormDatastoreSpec.
Fix a couple of Neo4j adapter correctness issues surfaced by the newer baseline (e.g., GraphClassMapping recursion and null-safe pagination handling).

Reviewed changes

Copilot reviewed 71 out of 71 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
grails-data-neo4j/grails-plugin/build.gradle	Remove Java 11 compatibility settings from plugin build.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/resources/META-INF/services/org.apache.grails.data.testing.tck.base.GrailsDataTckManager	Register Neo4j TCK manager via ServiceLoader for TCK specs.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/org/grails/datastore/gorm/neo4j/TransactionPropagationSpec.groovy	Migrate spec to new Neo4j TCK base spec and manager-scoped session access.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/org/grails/datastore/gorm/neo4j/Neo4jSuite.groovy	Remove legacy JUnit suite wrapper.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/org/grails/datastore/gorm/neo4j/ApiExtensionsSpec.groovy	Migrate spec to new TCK base and annotate known PR2 gaps as PendingFeature.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/org/apache/grails/data/neo4j/core/Neo4jGormDatastoreSpec.groovy	New Neo4j-specific base spec built on shared `GrailsDataTckSpec`.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/org/apache/grails/data/neo4j/core/GrailsDataNeo4jTckManager.groovy	New Neo4j TCK manager to share embedded server per spec and wire datastore/session lifecycle.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/WithTransactionSpec.groovy	Switch to Neo4j TCK base spec and TCK domain classes.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/ValidationSpec.groovy	Switch to Neo4j TCK base spec and manager-backed mapping/session usage.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/UniqueConstraintSpec.groovy	Jakarta migration (`javax.persistence` → `jakarta.persistence`) and new base spec.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/TransientsSpec.groovy	Switch to new base spec and manager-backed session operations.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/SchemalessSpec.groovy	Switch to new base spec; mark known dynamic-association issue as PendingFeature.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/RelationshipUtilsSpec.groovy	Switch to new base spec and shared TCK domains.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/RelationshipMappingSpec.groovy	Switch to new base spec and manager-backed session/datastore references.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/ReadManyObjectsSpec.groovy	Switch to new base spec and Jakarta persistence imports.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/ProxySpec.groovy	Switch to new base spec and manager-backed session lifecycle.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/ProjectionsSpec.groovy	Switch to new base spec and shared TCK domains.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/Pet.groovy	Align test domain imports with shared TCK domains.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/PersistenceEventListenerSpec.groovy	Switch to new base spec and manager-backed datastore wiring.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/path/RelationshipSpec.groovy	Mark GormRegistry-dependent behavior as PendingFeature (PR2).
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/path/PathSpec.groovy	Mark GormRegistry-dependent behavior as PendingFeature (PR2).
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/PagedResultSpec.groovy	Switch to new base spec and shared TCK Person domain.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/OrphanDeleteSpec.groovy	Switch to new base spec and manager-backed session clears.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/OptimisticLockingSpec.groovy	Switch to new base spec and adjust session references/comments accordingly.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/OneToOneSpec.groovy	Switch to new base spec and shared TCK domains for associations.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/OneToManyUpdateSpec.groovy	Switch to new base spec; mark static-API-dependent cypher behavior as PendingFeature.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/NullValueEqualSpec.groovy	Switch to new base spec and shared TCK TestEntity domain.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/Neo4jResultListSpec.groovy	Switch to new base spec and manager-backed session clearing.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/NativeIdentityGeneratorSpec.groovy	Switch to new base spec; mark saveAll/GormRegistry issue as PendingFeature.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/multitenancy/SingleTenancySpec.groovy	Replace removed Spring SocketUtils usage with ServerSocket-based port selection.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/multitenancy/MultiTenancySpec.groovy	Mark GormRegistry-dependent static API resolution as PendingFeature (PR2).
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/MultipleConnectionsSpec.groovy	Replace removed Spring SocketUtils usage with ServerSocket-based port selection.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/MiscSpec.groovy	Switch to new base spec and update session/datastore references to manager.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/MarkDirtyFalseSpec.groovy	Switch to new base spec; mark known dirty-checking gap as PendingFeature.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/MapPropertySpec.groovy	Switch to new base spec and domain registration pattern.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/ManyToManySpec.groovy	Switch to new base spec and update manager-backed session usage.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/ManyToManyQuerySpec.groovy	Switch to new base spec and domain registration pattern.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/LikeQuerySpec.groovy	Switch to new base spec and update transaction/session usage.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/LabelStrategySpec.groovy	Switch to new base spec and manager-backed serverControls/session usage.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/JoinCriteriaSpec.groovy	Switch to new base spec and manager-backed session clearing.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/JavaxValidationSpec.groovy	Switch to Jakarta validation annotations and new base spec.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/InheritanceProxySpec.groovy	Switch to new base spec and shared TCK Child domain.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/GroovyProxySpec.groovy	Switch to new base spec and manager-backed mappingContext proxyFactory changes.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/GormDatastoreSpec.groovy	Remove adapter-local legacy base test spec implementation.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/FindByIsNullSpec.groovy	Switch to new base spec and manager-backed session clearing.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/EagerFetchingSpec.groovy	Switch to new base spec and manager-backed proxyFactory assertions.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/CypherQueryStringSpec.groovy	Switch to new base spec and annotate PR2-dependent behaviors as PendingFeature.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/cypher/OneToManyCreateSpec.groovy	Mark known failing case as PendingFeature with updated reason.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/CustomLabelWithDynamicAssociationSpec.groovy	Switch to new base spec and manager-backed session clearing.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/CascadingDeleteSpec.groovy	Switch to new base spec and shared TCK domains for Pet/PetType.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/services/implementers/UpdateCypherQueryImplementer.groovy	Adjust implementer typing/compatibility for Groovy 4 baseline.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/services/implementers/StatementResultCypherQueryImplementer.groovy	Adjust implementer typing/compatibility for Groovy 4 baseline.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/services/implementers/FindPathCypherQueryImplementer.groovy	Adjust implementer typing/compatibility for Groovy 4 baseline.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/services/implementers/FindOneCypherQueryImplementer.groovy	Adjust implementer typing/compatibility for Groovy 4 baseline.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/services/implementers/FindAllCypherQueryImplementer.groovy	Adjust implementer typing/compatibility for Groovy 4 baseline.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/Neo4jSession.java	Jakarta persistence migration + safer custom-type casting.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/Neo4jDatastoreTransactionManager.java	Jakarta persistence migration for FlushModeType.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/Neo4jDatastore.java	Jakarta migration (`PreDestroy`, `FlushModeType`).
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/GraphGormMappingFactory.groovy	Add identity-mapping fallback for custom/named id generators.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/GraphClassMapping.groovy	Fix Groovy 4 recursion by using explicit field access for mappedForm.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/engine/Neo4jQuery.groovy	Jakarta migration + null-safe offset/max handling and type tweaks.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/engine/Neo4jEntityPersister.java	Jakarta persistence migration (FetchType/LockModeType).
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/engine/Neo4jAssociationQueryExecutor.groovy	Jakarta persistence migration (FetchType).
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/collection/Neo4jResultList.groovy	Jakarta persistence migration (LockModeType).
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/collection/Neo4jPath.groovy	Groovy 4 generic compatibility adjustments for iterator typing.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/api/Neo4jGormStaticApi.groovy	Override saveAll to return persisted ids; tighten some casts.
grails-data-neo4j/grails-datastore-gorm-neo4j/build.gradle	Update test dependencies (TCK), force compatible Jetty/driver versions, add JVM opens, adjust test parallelism.
grails-data-neo4j/gradle.properties	Bump versions to GORM 8 / Grails 8 / Groovy 4 / Spring 7 / Boot 4.1 baseline.
grails-data-neo4j/GORM_REGISTRY_MIGRATION.md	Add documentation describing PR1/PR2 migration plan for GormRegistry wiring.
grails-data-neo4j/build.gradle	Enable mavenLocal buildscript resolution; switch Groovy deps to org.apache.groovy; apply test-retry plugin; set Java 21 toolchain.
grails-data-neo4j/boot-plugin/build.gradle	Switch Groovy exclusions/deps from org.codehaus.groovy to org.apache.groovy.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-07-03T03:40:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.6213%. Comparing base (3914546) to head (c024658).

Additional details and impacted files

@@                          Coverage Diff                           @@
##             feat/gorm-registry-core-impl     #15816        +/-   ##
======================================================================
- Coverage                         49.6432%   49.6213%   -0.0219%     
+ Complexity                          17043      17032        -11     
======================================================================
  Files                                1961       1961                
  Lines                               93737      93738         +1     
  Branches                            16466      16465         -1     
======================================================================
- Hits                                46534      46514        -20     
- Misses                              39960      39983        +23     
+ Partials                             7243       7241         -2

Files with missing lines	Coverage Δ
...org/grails/datastore/gorm/GormValidationApi.groovy	`50.7463% <ø> (-0.7243%)`	⬇️
.../data/testing/tck/tests/WithTransactionSpec.groovy	`100.0000% <100.0000%> (ø)`

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- GrailsDataNeo4jTckManager#destroy(): the per-test graph-wipe transaction and session were never explicitly closed (only relying on commit()/an outer finally on the session). Use withCloseable on both so the transaction and session are always released, including on failure paths. - grails-data-neo4j/build.gradle: scope both buildscript- and root-level mavenLocal() to org.apache.grails* groups only, so it's only consulted for locally-published Grails/GORM snapshots and can't accidentally shadow other dependencies with unrelated locally-published artifacts. - grails-datastore-gorm-neo4j/build.gradle: the Jetty version force is now scoped to testCompileClasspath/testRuntimeClasspath only, since main code never touches Jetty directly (it's only needed by the test-only embedded Neo4j harness). The neo4j-java-driver force stays applied to all configurations, since main code (Neo4jQuery#executeQuery) also depends on the pinned driver version. Verified: BUILD SUCCESSFUL, 0 failures (181/215 passing, 34 pending - unchanged from before these fixes). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

grails-data-neo4j is a separate Gradle build on an older baseline (Groovy 3.0.25 / Grails 6.0.0 / javax) consuming published GORM. Document the two-PR path to wire it to the GormRegistry O(M+N) work: PR1 migrates the build to the Groovy 4 / Java 21 / Jakarta baseline and onto core-impl's GORM (8.0.0-SNAPSHOT); PR2 adds Neo4jGormApiFactory + registration and rewrites the entity traits from GormEnhancer to GormRegistry. To be executed once #15780 CI confirms the GormRegistry SPI is stable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Baseline migration (PR1 of the Neo4j GormRegistry migration plan): bumps grails-data-neo4j's dependency stack to match root-repo (Groovy 4.0.32, Jakarta EE 10, GORM 8.0.0-SNAPSHOT, Spring Boot 4.1), with no GormRegistry behavioral change. The module previously didn't compile against these versions at all; it now compiles and its test suite runs (181/215 passing, 34 explicitly @PendingFeature with documented reasons, 0 unaccounted failures). Build/dependency fixes: - Force Jetty to 9.4.43 and neo4j-java-driver to 4.4.13 on the test classpath: Spring Boot 4.1's BOM silently upgrades both to binary-incompatible major versions, breaking the embedded test server and Driver#defaultTypeSystem(). - Add --add-opens for java.lang and sun.nio.ch: the embedded Neo4j 3.5.x kernel reflects into JDK internals that JDK 9+ blocks by default. - Replace dead javax.el/el-impl with jakarta.el/expressly, and add geantyref and byte-buddy (both needed by Spock's Mock() at runtime but not declared as spock-core dependencies). Two real, previously-latent bugs fixed in Neo4j's own source: - GraphClassMapping#getMappedForm(): ambiguous Groovy property syntax now resolves to a method call under Groovy 4, causing infinite recursion with PersistentEntity's default interface method. Fixed with explicit field access. - Neo4jQuery#applyOrderAndLimits(): checked offset != 0 / max != -1, but Query#offset/max are now boxed Integers defaulting to null (not 0/-1), so most unpaginated queries crashed binding a null SKIP parameter. This alone was blocking the majority of the test suite. - GormStaticApi#saveAll()'s shared implementation returns session.flush()'s result (void) instead of the persisted ids; fixed via override in Neo4jGormStaticApi (dormant until PR2 registers the API factory, see below). - GraphGormMappingFactory: added a createDefaultIdentityMapping() override so named/custom id generators (e.g. "snowflake") fall back to ValueGenerator.CUSTOM instead of throwing, mirroring Hibernate's existing handling of this same gap in the shared base class. TCK migration: introduces GrailsDataNeo4jTckManager + Neo4jGormDatastoreSpec, migrating all 37 spec files off the old adapter-specific GormDatastoreSpec onto the shared grails-datamapping-tck framework, matching the pattern already used by Hibernate5/7 and MongoDB. A single embedded server is reused per spec class instead of restarted per test. Restores the old base spec's per-spec getConfiguration() override point, which the initial migration had dropped. The remaining 34 pending tests are annotated with the exact reason each is blocked: the majority (~19) on Neo4jGormApiFactory not yet being registered with GormRegistry (PR2 scope - static/cypher-string API calls resolve to the generic GormStaticApi instead of Neo4jGormStaticApi), plus a handful of narrower, individually-documented gaps not yet root-caused. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

- GrailsDataNeo4jTckManager#destroy(): the per-test graph-wipe transaction and session were never explicitly closed (only relying on commit()/an outer finally on the session). Use withCloseable on both so the transaction and session are always released, including on failure paths. - grails-data-neo4j/build.gradle: scope both buildscript- and root-level mavenLocal() to org.apache.grails* groups only, so it's only consulted for locally-published Grails/GORM snapshots and can't accidentally shadow other dependencies with unrelated locally-published artifacts. - grails-datastore-gorm-neo4j/build.gradle: the Jetty version force is now scoped to testCompileClasspath/testRuntimeClasspath only, since main code never touches Jetty directly (it's only needed by the test-only embedded Neo4j harness). The neo4j-java-driver force stays applied to all configurations, since main code (Neo4jQuery#executeQuery) also depends on the pinned driver version. Verified: BUILD SUCCESSFUL, 0 failures (181/215 passing, 34 pending - unchanged from before these fixes). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Rebasing build/neo4j-groovy4-baseline onto current 8.0.x (which has moved to Groovy 5.0.7) surfaced 18 failing tests beyond the baseline migration's own known-pending set. Root-caused and fixed the following: - Bump grails-data-neo4j's own groovyVersion/spockVersion to 5.0.7 / 2.4-groovy-5.0 to match what the rest of 8.0.x now resolves; the module's properties were stale at 4.0.32, causing Spock to refuse to run entirely. - Neo4jQuery: widen the to-one association id-collection condition so a mandatory (non-nullable), lazy to-one also has its real id collected, fixing <property>Id lookups that were silently returning the parent's id instead (OneToOneSpec); add IS NULL fallbacks for the NOT_EQUALS and EQUALS(null) comparison operators, matching GORM's non-SQL-null-semantics expectations for countByXNotEqual and findWhere/findAllWhere(prop: null). - Neo4jGormStaticApi: add the missing narrowing cast the stricter Groovy 5 compiler now requires for executeUpdate's long-to-Integer return. - GormValidationApi (grails-datamapping-core): getValidator() permanently cached the first auto-discovered validator instead of re-resolving from the MappingContext on each call - harmless for adapters that build a fresh datastore per test, but silently ignored every later test's registered mock validator for adapters (Neo4j) that reuse one datastore across a whole spec class. Re-resolve on every call unless explicitly overridden via setValidator(). - WithTransactionSpec (grails-datamapping-tck): wrap the three withNewTransaction rollback scenarios in a fresh thread - Neo4j has no ambient-session nested-transaction support, so running on the same thread as the TCK harness's own per-test transaction silently bypassed the rollback under test; a fresh thread has no ambient session, matching the workaround the module's own legacy WithTransactionSpec already used. - Two legacy grails.gorm.tests specs (OneToOneSpec, OneToManyUpdateSpec) had assertions written against the very bugs fixed above (asserting a DataIntegrityViolationException / a swapped id as "expected" behavior); updated both to assert the now-correct behavior. Remaining known-accepted failures (pre-existing, not caused by this rebase): OneToManySpec (a inverse-collection-timing fix attempt caused a worse regression in AssignedIdSpec and was reverted), OptimisticLockingSpec and FindWhereSpec (confirmed Neo4j-adapter-specific via H5/H7/Mongo all passing the identical shared TCK tests), plus 3 tests that now pass under @PendingFeatureIf but still report as such due to an unresolved Spock condition-evaluation timing quirk. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

testlens-app · 2026-07-05T00:33:05Z

✅ All tests passed ✅

🏷️ Commit: c024658
▶️ Tests: 18095 executed
⚪️ Checks: 39/39 completed

Learn more about TestLens at testlens.app.

jdaugherty · 2026-07-05T12:59:14Z

I'm confused - neo4j is right now not bound to the settings.gradle. This doesn't appear to update it for Grails 7 though. Is there another PR or are you updating the files separately due to the gorm api changes?

…radle Answers reviewer question on #15816 about why grails-data-neo4j isn't wired into root settings.gradle yet: it follows the same graphql precedent (0e04cf1), just not folded in as this PR's scope.

borinquenkid · 2026-07-05T14:21:26Z

Thanks for flagging this, James — you're right that this PR doesn't touch settings.gradle.

Neo4j and graphql were both moved into this repo standalone (0e04cf1463) as a holding pattern while they hadn't caught up to the current baseline. graphql has since finished that migration and was folded into root settings.gradle for real; this PR is the neo4j equivalent of that first step — get it compiling and passing tests against core-impl's GORM (8.0.0-SNAPSHOT) while still a separate build, then wire it into GormRegistry (PR2, already up), then fold it into root settings.gradle the same way graphql was (PR3).

I've written up that PR3 scope in grails-data-neo4j/GORM_REGISTRY_MIGRATION.md on this branch so it's tracked rather than implied.

jdaugherty · 2026-07-05T15:36:24Z

FYI: https://github.com/apache/grails-core/tree/grails7-initial-neo4jUpdates already exists as an initial update pass

Copilot AI review requested due to automatic review settings July 3, 2026 03:09

github-project-automation Bot added this to Apache Grails Jul 3, 2026

Copilot started reviewing on behalf of borinquenkid July 3, 2026 03:09 View session

Copilot AI reviewed Jul 3, 2026

View reviewed changes

Comment thread ...orm-neo4j/src/test/groovy/org/apache/grails/data/neo4j/core/GrailsDataNeo4jTckManager.groovy Outdated

Comment thread grails-data-neo4j/build.gradle

Comment thread grails-data-neo4j/grails-datastore-gorm-neo4j/build.gradle

borinquenkid mentioned this pull request Jul 3, 2026

Wire Neo4j adapter to GormRegistry's GormApiFactory mechanism (PR2) #15817

Open

2 tasks

borinquenkid force-pushed the feat/gorm-registry-core-impl branch from e4773df to 3914546 Compare July 4, 2026 22:25

borinquenkid force-pushed the build/neo4j-groovy4-baseline branch from 85799cd to c56a14c Compare July 4, 2026 22:25

borinquenkid and others added 4 commits July 4, 2026 18:23

borinquenkid force-pushed the build/neo4j-groovy4-baseline branch from c56a14c to c024658 Compare July 4, 2026 23:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Migrate grails-data-neo4j to Groovy 4/Jakarta/GORM 8 baseline#15816

Migrate grails-data-neo4j to Groovy 4/Jakarta/GORM 8 baseline#15816
borinquenkid wants to merge 4 commits into
feat/gorm-registry-core-implfrom
build/neo4j-groovy4-baseline

borinquenkid commented Jul 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jul 3, 2026 •

edited

Loading

Uh oh!

testlens-app Bot commented Jul 5, 2026

Uh oh!

jdaugherty commented Jul 5, 2026

Uh oh!

borinquenkid commented Jul 5, 2026

Uh oh!

jdaugherty commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

borinquenkid commented Jul 3, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

testlens-app Bot commented Jul 5, 2026

✅ All tests passed ✅

Uh oh!

jdaugherty commented Jul 5, 2026

Uh oh!

borinquenkid commented Jul 5, 2026

Uh oh!

jdaugherty commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Jul 3, 2026 •

edited

Loading