Skip to content

HBASE-30195 Update Thrift gateway to use new hbase-shaded-thrift in thirdparty#8396

Merged
apurtell merged 1 commit into
apache:branch-2from
apurtell:HBASE-30195-branch-2
Jun 26, 2026
Merged

HBASE-30195 Update Thrift gateway to use new hbase-shaded-thrift in thirdparty#8396
apurtell merged 1 commit into
apache:branch-2from
apurtell:HBASE-30195-branch-2

Conversation

@apurtell

Copy link
Copy Markdown
Contributor

On apache/hbase-thirdparty#160 we onboard libthrift to hbase-thirdparty so we can consume libthrift security fixes while maintaining Java 8 compatibility for HBase branch-2, branch-2.5, and branch-2.6.

Use the new hbase-shaded-thrift in hbase-thirdparty.

branch-2 companion to #8299

@liuxiaocs7 liuxiaocs7 added the backport This PR is a back port of some issue or issues already committed to master label Jun 23, 2026
@apurtell

Copy link
Copy Markdown
Contributor Author

Let me see what happened here locally and solve this before merging the master PR.

…hirdparty

Co-Authored-by: Claude <noreply@anthropic.com>
@apurtell apurtell force-pushed the HBASE-30195-branch-2 branch from 5f3b77a to f4fbb25 Compare June 24, 2026 22:11
@apurtell

Copy link
Copy Markdown
Contributor Author

Ok, rebased on branch-2 and done properly.

@apurtell

Copy link
Copy Markdown
Contributor Author

Looking better. There is a flaky test, TestAsyncProcess, that is not related to this change but needs follow up. Thrift tests pass.

@apurtell

Copy link
Copy Markdown
Contributor Author

Carrying over signoffs from master version. The only difference here is generation of Thrift gen-sources from the IDL that ships in branch-2.

@apurtell apurtell merged commit 705610a into apache:branch-2 Jun 26, 2026
17 of 20 checks passed
@apurtell apurtell deleted the HBASE-30195-branch-2 branch June 26, 2026 23:26
asf-gitbox-commits pushed a commit that referenced this pull request Jun 26, 2026
…hirdparty (#8396)

Signed-off-by: Dávid Paksy <paksyd@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
asf-gitbox-commits pushed a commit that referenced this pull request Jun 27, 2026
…hirdparty (#8396)

Amended to apply to branch-2.5; regenerate Thrift with -Pcompile-thrift

Signed-off-by: Dávid Paksy <paksyd@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants