Skip to content

HBASE-30252 hbase snapshot info display inaccurate snapshot TTL information messages (branch-2) #8411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guluo2016 wants to merge 1 commit into
base: branch-2
Choose a base branch
from
+34 −13
Open

HBASE-30252 hbase snapshot info display inaccurate snapshot TTL information messages (branch-2) #8411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 34 additions & 13 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
*/
package org.apache.hadoop.hbase.snapshot;

import static org.apache.hadoop.hbase.HConstants.DEFAULT_SNAPSHOT_TTL;

import java.io.FileNotFoundException;
import java.io.IOException;
import java.net.URI;
Expand Down Expand Up @@ -71,6 +73,10 @@
public final class SnapshotInfo extends AbstractHBaseTool {
private static final Logger LOG = LoggerFactory.getLogger(SnapshotInfo.class);

private static final String EXPIRED_LABEL = "Yes";
private static final String NOT_EXPIRED_LABEL = "No";
private static final String TTL_FOREVER = "FOREVER";

static final class Options {
static final Option SNAPSHOT =
new Option(null, "snapshot", true, "The name of the snapshot to be detailed.");
Expand Down Expand Up @@ -391,11 +397,18 @@ public int doWork() throws IOException, InterruptedException {
// List Available Snapshots
if (listSnapshots) {
SimpleDateFormat df = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss");
System.out.printf("%-20s | %-20s | %-20s | %s%n", "SNAPSHOT", "CREATION TIME", "TTL IN SEC",
"TABLE NAME");
for (SnapshotDescription desc : getSnapshotList(conf)) {
System.out.printf("%-20s | %20s | %20s | %s%n", desc.getName(),
df.format(new Date(desc.getCreationTime())), desc.getTtl(), desc.getTableNameAsString());
List<SnapshotDescription> snapshotDescriptions = getSnapshotList(conf);
System.out.printf("%-20s | %-20s | %-20s | %-20s | %s%n", "SNAPSHOT", "CREATION TIME",
"TTL(Sec)", "EXPIRED", "TABLE NAME");
long currentTime = System.currentTimeMillis();
for (SnapshotDescription desc : snapshotDescriptions) {
String ttlInfo =
desc.getTtl() == DEFAULT_SNAPSHOT_TTL ? TTL_FOREVER : String.valueOf(desc.getTtl());
String expired = SnapshotDescriptionUtils.isExpiredSnapshot(desc.getTtl(),
desc.getCreationTime(), currentTime) ? EXPIRED_LABEL : NOT_EXPIRED_LABEL;
System.out.printf("%-20s | %20s | %20s | %20s | %s%n", desc.getName(),
df.format(new Date(desc.getCreationTime())), ttlInfo, expired,
desc.getTableNameAsString());
}
return 0;
}
Expand Down Expand Up @@ -443,15 +456,23 @@ private boolean loadSnapshotInfo(final String snapshotName) throws IOException {
private void printInfo() {
SnapshotProtos.SnapshotDescription snapshotDesc = snapshotManifest.getSnapshotDescription();
SimpleDateFormat df = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss");
String ttlInfo = snapshotDesc.getTtl() == DEFAULT_SNAPSHOT_TTL
? TTL_FOREVER
: String.valueOf(snapshotDesc.getTtl());
String expired = SnapshotDescriptionUtils.isExpiredSnapshot(snapshotDesc.getTtl(),
snapshotDesc.getCreationTime(), System.currentTimeMillis())
? EXPIRED_LABEL
: NOT_EXPIRED_LABEL;
System.out.println("Snapshot Info");
System.out.println("----------------------------------------");
System.out.println(" Name: " + snapshotDesc.getName());
System.out.println(" Type: " + snapshotDesc.getType());
System.out.println(" Table: " + snapshotDesc.getTable());
System.out.println(" Format: " + snapshotDesc.getVersion());
System.out.println("Created: " + df.format(new Date(snapshotDesc.getCreationTime())));
System.out.println(" Ttl: " + snapshotDesc.getTtl());
System.out.println(" Owner: " + snapshotDesc.getOwner());
System.out.println("-----------------------------------------");
System.out.println(" Name: " + snapshotDesc.getName());
System.out.println(" Type: " + snapshotDesc.getType());
System.out.println(" Table: " + snapshotDesc.getTable());
System.out.println(" Format: " + snapshotDesc.getVersion());
System.out.println(" Created: " + df.format(new Date(snapshotDesc.getCreationTime())));
System.out.println("Ttl(Sec): " + ttlInfo);
System.out.println(" Expired: " + expired);
System.out.println(" Owner: " + snapshotDesc.getOwner());
System.out.println();
}

Expand Down
Loading