HIVE-29807 - #6700
Open
dengzhhu653 wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Hive’s analysis/authorization plumbing so that materialized CTEs propagate their underlying base-table inputs and column-access information (including nested materialized CTEs). This makes EXPLAIN hooks/test outputs and legacy authorization (V1) reflect the real tables/columns accessed, rather than only the temporary materialized CTE tables.
Changes:
- Switch multiple call sites (EXPLAIN, hooks, authorizer helpers) from
getInputs()togetAllInputs()/getAllOutputs()so materialized-CTE sub-analyzer entities are included. - Merge column-access info from materialized CTE sub-analyzers into the parent analyzer’s
ColumnAccessInfoto support column-level authorization on base tables. - Update LLAP q-test golden outputs and add a unit test for materialized CTE inputs + column access.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ql/src/java/org/apache/hadoop/hive/ql/security/authorization/command/CommandAuthorizer.java | Use getAllInputs/getAllOutputs so authorization sees entities from materialized CTE sub-analyzers. |
| ql/src/java/org/apache/hadoop/hive/ql/security/authorization/command/CommandAuthorizerV1.java | Fall back to ColumnAccessInfo for table authorization column lists when direct scan-derived columns aren’t present. |
| ql/src/java/org/apache/hadoop/hive/ql/plan/ExplainWork.java | Populate EXPLAIN work inputs using getAllInputs(). |
| ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java | EXPLAIN formatted JSON uses getAllInputs() for auth-related entities. |
| ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java | EXPLAIN semantic analyzer tracks getAllInputs(). |
| ql/src/java/org/apache/hadoop/hive/ql/parse/DeleteSemanticAnalyzer.java | DELETE metadata-update path now uses getAllInputs() for inputs. |
| ql/src/java/org/apache/hadoop/hive/ql/parse/HiveSemanticAnalyzerHookContextImpl.java | Hook context inputs now include materialized CTE base-table reads via getAllInputs(). |
| ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java | Transaction requirement check now considers getAllInputs() (materialized CTE sources included). |
| ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java | getAllInputs/getAllOutputs recurse into materialized CTE analyzers; column-access attachment now targets getAllInputs; results cache query info now stores getAllInputs. |
| ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnAccessInfo.java | Add merge(ColumnAccessInfo) helper for combining direct column accesses. |
| ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnAccessAnalyzer.java | Merge materialized CTE sub-analyzer column access into the current analyzer’s column access info. |
| ql/src/test/org/apache/hadoop/hive/ql/parse/TestSemanticAnalyzer.java | Add unit test asserting getInputs() hides base tables for materialized CTEs while getAllInputs() and column access include them. |
| ql/src/test/results/clientpositive/llap/cte_mat_type.q.out | Update expected PREHOOK/POSTHOOK inputs to include base tables. |
| ql/src/test/results/clientpositive/llap/cte_mat_9.q.out | Update expected PREHOOK/POSTHOOK inputs to include materialized CTE table. |
| ql/src/test/results/clientpositive/llap/cte_mat_5.q.out | Update expected PREHOOK/POSTHOOK inputs to include base table src. |
| ql/src/test/results/clientpositive/llap/cte_mat_4.q.out | Update expected PREHOOK/POSTHOOK inputs to include base table src. |
| ql/src/test/results/clientpositive/llap/cte_mat_3.q.out | Update expected PREHOOK/POSTHOOK inputs to include base table src. |
| ql/src/test/results/clientpositive/llap/cte_mat_11.q.out | Update expected PREHOOK/POSTHOOK inputs to include nested materialized CTE/base-table inputs. |
| ql/src/test/results/clientpositive/llap/cte_3.q.out | Update expected PREHOOK/POSTHOOK inputs to include dependent CTE/base-table inputs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| } | ||
| } | ||
| // Every Analyzer holds its private rootClause |
| } | ||
|
|
||
| private final CTEClause rootClause = new CTEClause(null, null, null); | ||
| final CTEClause rootClause = new CTEClause(null, null, null); |
Comment on lines
+575
to
+578
| SemanticAnalyzer analyzer = (SemanticAnalyzer) SemanticAnalyzerFactory.get(queryState, astNode); | ||
| analyzer.initCtx(ctx); | ||
| analyzer.analyze(astNode, ctx); | ||
| analyzers[i] = analyzer; |
asf-ci-hive
added
tests unstable
tests pending
tests passed
and removed
tests pending
tests unstable
labels
kasakrisz
requested changes
Aug 18, 2026
Comment on lines
+37
to
+38
| public ColumnAccessInfo analyzeColumnAccess(SemanticAnalyzer analyzer) throws SemanticException { | ||
| ColumnAccessInfo columnAccessInfo = analyzer.getColumnAccessInfo(); |
Contributor
There was a problem hiding this comment.
Why was ColumnAccessInfo replaced with SemanticAnalyzer? The reference analyzer is not used elsewhere in this method.
Member
Author
There was a problem hiding this comment.
It's used in getMaterializedCteColumnAccessInfo(analyzer.rootClause.asExecutionOrder()) to merge parent CTEs column access
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
dengzhhu653
marked this pull request as ready for review
August 19, 2026 23:45
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?