bug: TruncateTransform.project when length > width#3519
Open
rambleraptor wants to merge 2 commits into
Open
Conversation
rambleraptor
changed the title
ebyhr
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We've diverged from the Java implementation for TruncateTransform.project
In Java, we return
nullwhen length > width. This means that the predicate can't be projected.Are these changes tested?
We had one test that was (incorrectly) passing. I've changed up the test to test the three use-cases:
length < width,length == width,length > width. This better matches the test suite from Java.Are there any user-facing changes?