docs: add postgres example for sql catalog#2215
Open
jdockerty wants to merge 3 commits intoapache:mainfrom
Open
docs: add postgres example for sql catalog#2215jdockerty wants to merge 3 commits intoapache:mainfrom
jdockerty wants to merge 3 commits intoapache:mainfrom
Conversation
blackmwk
approved these changes
Mar 6, 2026
Contributor
blackmwk
left a comment
blackmwk
left a comment
There was a problem hiding this comment.
Thanks @jdockerty for this pr!
Contributor
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
Contributor
Author
|
@blackmwk I missed that this had a CI flake. I've updated the PR and everything is passing now, are you fine with merging this as-is now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No specific issue, although I can raise one for this if required.
What changes are included in this PR?
This expands the documentation for the
sqlcatalog implementation to include apostgresspecific example.Perhaps the usage was obvious enough from the current "generic" example, but I found that the example showing the SQL server URI as a HTTP server a little confusing. I've left this here as I think it is still useful, but also provided a more postgres tailored one in order to show "real database" usage, rather than simply filling in the values.
In any case, I don't think more documentation can hurt 😄
Are these changes tested?
N/A