Skip to content

Increase the throughput of the validate_duplicate_files #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomighita wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Increase the throughput of the validate_duplicate_files #2296

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d10f6b
Implement futures unordered when checking
tomighita Mar 30, 2026
96777d5
Merge branch 'main' into tomighita/increase-duplicate-check-throughput
tomighita Mar 30, 2026
65da6db
Change to task per fetch
tomighita Mar 31, 2026
b9d544f
Move to buffered and threads
tomighita Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions crates/iceberg/src/transaction/snapshot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ use std::collections::{HashMap, HashSet};
use std::future::Future;
use std::ops::RangeFrom;

use futures::{StreamExt, TryStreamExt};
use uuid::Uuid;

use crate::error::Result;
use crate::runtime::spawn;
use crate::spec::{
DataFile, DataFileFormat, FormatVersion, MAIN_BRANCH, ManifestContentType, ManifestEntry,
ManifestFile, ManifestListWriter, ManifestWriter, ManifestWriterBuilder, Operation, Snapshot,
Expand Down Expand Up @@ -175,17 +177,24 @@ impl<'a> SnapshotProducer<'a> {
let manifest_list = current_snapshot
.load_manifest_list(self.table.file_io(), &self.table.metadata_ref())
.await?;
for manifest_list_entry in manifest_list.entries() {
let manifest = manifest_list_entry
.load_manifest(self.table.file_io())
.await?;
for entry in manifest.entries() {
let file_path = entry.file_path();
if new_files.contains(file_path) && entry.is_alive() {
referenced_files.push(file_path.to_string());

let entries: Vec<_> = manifest_list.consume_entries().into_iter().collect();
futures::stream::iter(entries)
.map(|entry| {
let file_io = self.table.file_io().clone();
spawn(async move { entry.load_manifest(&file_io).await })
})
.buffer_unordered(32)
.try_for_each(|manifest| {
for entry in manifest.entries() {
let file_path = entry.file_path();
if new_files.contains(file_path) && entry.is_alive() {
referenced_files.push(file_path.to_string());
}
}
}
}
std::future::ready(Ok(()))
})
.await?;
}

if !referenced_files.is_empty() {
Expand Down
Loading