Open
Conversation
xanderbailey
force-pushed
the
feat/delete-file-footer-metadata
branch
from
adabbda to
25d659c
Compare
xanderbailey
changed the title
xanderbailey
force-pushed
the
feat/delete-file-footer-metadata
branch
from
25d659c to
de2e36a
Compare
xanderbailey
force-pushed
the
feat/delete-file-footer-metadata
branch
from
de2e36a to
18b88b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Equality delete files written by iceberg-rust are missing the
delete-typeanddelete-field-idskey-value metadata in the Parquet file footer. Java writes these inParquet.java#L1017-L1022ORC also does this but we don't support ORC in rust.
This PR adds a
with_footer_metadata(key, value)method to theFileWriterBuildertrait and wires it up soEqualityDeleteFileWriterBuilder::new()automatically injects the metadata. The metadata is now written without callers having to remember to set it.The trait-level approach was chosen over a Parquet-specific helper because Java writes the same metadata across all three file formats. A future ORC or Avro writer can implement
with_footer_metadataand the delete writers will work without changes.Trade-off: adding a required method to
FileWriterBuilderis a breaking change for any out-of-tree implementations of the trait.ParquetWriterBuilderis the only implementation today so this shouldn't affect anyone in practice.Position delete writers don't exist yet in iceberg-rust, but when they do, the same
with_footer_metadataplumbing can be used to adddelete-type: position.Are these changes tested?
Yes