fix(rest-catalog): omit null optional fields in CreateTableRequest JSON#2335
Open
jonbjo wants to merge 2 commits intoapache:mainfrom
Open
fix(rest-catalog): omit null optional fields in CreateTableRequest JSON#2335jonbjo wants to merge 2 commits intoapache:mainfrom
jonbjo wants to merge 2 commits intoapache:mainfrom
Conversation
added 2 commits
April 15, 2026 20:17
Add test to verify that optional fields are properly omitted (not serialized as null) when None, addressing reviewer feedback. Test cases cover both full serialization with all optional fields present and minimal serialization with only required fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the serialization of optional fields in
CreateTableRequestand related types to ensure they are omitted (rather than serialized asnull) whenNone.This addresses issue where REST catalog implementations may reject requests with explicit
nullvalues for optional fields.Changes
#[serde(skip_serializing_if = "Option::is_none")]to optional fields in:CreateTableRequest:location,partition_spec,write_order,stage_createUnboundPartitionField:field_idUnboundPartitionSpec:spec_idtest_create_table_request_serdeto verify serialization behaviorTest Plan
Added unit test that verifies:
Related
Closes #2135