Draft
Conversation
xanderbailey
force-pushed
the
xb/incremental_read
branch
from
e88d444 to
11cce80
Compare
xanderbailey
commented
Apr 16, 2026
Comment on lines
+36
to
+43
| /// Filter applied to each [`ManifestFile`] before fetching it. | ||
| /// Returns `true` to include the manifest, `false` to skip it. | ||
| pub(crate) type ManifestFileFilter = Arc<dyn Fn(&ManifestFile) -> bool + Send + Sync>; | ||
|
|
||
| /// Filter applied to each manifest entry after loading a manifest. | ||
| /// Returns `true` to include the entry, `false` to skip it. | ||
| pub(crate) type ManifestEntryFilter = Arc<dyn Fn(&ManifestEntryRef) -> bool + Send + Sync>; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I think this is a nice way to inject these filters and should extend to other future scans
xanderbailey
commented
Apr 16, 2026
| pub manifest_entry_filter: Option<ManifestEntryFilter>, | ||
| } | ||
|
|
||
| impl std::fmt::Debug for PlanContext { |
Contributor
Author
There was a problem hiding this comment.
ManifestFileFilter and ManifestEntryFilter can't be debug
CTTY
reviewed
Apr 16, 2026
| pub(crate) struct AppendSnapshotSet { | ||
| /// Snapshot IDs in the range | ||
| snapshot_ids: HashSet<i64>, | ||
| } |
Collaborator
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
ancestors_between is used here. We need to add validation and operation-type checking on top of it, we're not re-implementing the traversal. Does that make sense?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?