Skip to content

Fix test clean directory deletion#17860

Merged
jt2594838 merged 1 commit into
apache:masterfrom
Caideyipi:fix-environment-clean-dir
Jun 18, 2026
Merged

Fix test clean directory deletion#17860
jt2594838 merged 1 commit into
apache:masterfrom
Caideyipi:fix-environment-clean-dir

Conversation

@Caideyipi

@Caideyipi Caideyipi commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Make EnvironmentUtils.cleanDir recursively delete test directories with retry.
  • Route EnvironmentUtils.recursiveDeleteFolder through the same recursive cleanup path.
  • Replace one-level/manual UT directory cleanup with recursive cleanup in ConfigurationFileUtilsTest, FileUtilsTest, PipeTaskInfoConsensusPipeTest, AbstractRepairDataTest, and PipeDataNodePluginAgentTest.
  • Add coverage for nested directory cleanup.

Tests

  • mvn -Ddevelocity.off=true -pl iotdb-core/datanode,iotdb-core/node-commons,iotdb-core/confignode spotless:apply
  • mvn -Ddevelocity.off=true -pl iotdb-core/datanode spotless:apply
  • mvn -Ddevelocity.off=true -pl iotdb-core/node-commons -Dtest=FileUtilsTest test
  • mvn -Ddevelocity.off=true -pl iotdb-core/confignode -Dtest=PipeTaskInfoConsensusPipeTest test
  • Not run to completion locally: mvn -Ddevelocity.off=true -pl iotdb-core/datanode -Dtest=EnvironmentUtilsTest,ConfigurationFileUtilsTest,MergeTreeSortOperatorTest test (blocked by existing datanode compilation errors around MemoryReservationManager.reserveMemoryImmediately signature mismatch).

@Caideyipi Caideyipi force-pushed the fix-environment-clean-dir branch from f0aa659 to 9c6f50a Compare June 8, 2026 07:25
@Caideyipi Caideyipi force-pushed the fix-environment-clean-dir branch from 9c6f50a to 62661af Compare June 8, 2026 07:46
@jt2594838 jt2594838 merged commit ddc6554 into apache:master Jun 18, 2026
41 checks passed
@jt2594838 jt2594838 deleted the fix-environment-clean-dir branch June 18, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants